Update proxy setting section #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two changes: 1. Use `https_proxy` rather than `http_proxy` because the latter doesn't work at all. All traffic from rustup seems to go via https. 2. Use SOCKS proxy as example, since it is nowadays more widely-used (thanks to GFW in China) and more powerful. Also, avoiding using two `http`s makes it more obvious that other proxy types are also supported without needing to check the manual of curl.
|
For the first change, you can test that, specifying an invalid proxy on |
|
📌 Commit 9849424 has been approved by |
bors
added a commit
that referenced
this pull request
May 10, 2017
Update proxy setting section There are two changes: 1. Use `https_proxy` rather than `http_proxy` because the latter doesn't work at all. All traffic from rustup seems to go via https. 2. Use SOCKS proxy as example, since it is nowadays more widely-used (thanks to GFW in China) and more powerful. Also, avoiding using two `http`s makes it more obvious that other proxy types are also supported without needing to check the manual of curl.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes:
https_proxyrather thanhttp_proxybecause the latter doesn't work at all. All traffic from rustup seems to go via https.https makes it more obvious that other proxy types are also supported without needing to check the manual of curl.