Indent help text

[babbageclunk]

Add a DISCUSSION heading to each item and indent (and rewrap) the help text.

Fixes #940.

[brson]

Thanks @babbageclunk!

@kbknapp I wonder if you can peek at this and suggest whether it's the right way. My understanding of this issue is that we are trying to imitate claps generated formatting manually. Can clap itself produce formatting like this for these freeform text bits.

[kbknapp]

@brson Unfortunately this is the best way at this time.

The after_help portion is designed to be free-form and thus all headers and formatting are left to users. The only thing that after_help does do is rewrap properly at word boundaries. But since rustup is already using hard newline wrapping this isn't really an issue.

With the current PR, if someone has a terminal window with < 70 (I think?) columns the rewrapping that clap will do won't respect the hard tabs (or 4x spaces). However, someone with a terminal window that small is probably a rare-ish occurrence.

I'm open to someone adding the ability for clap to respect the starting indentation when using templates, and would be willing to mentor such efforts. I just don't have time to implement it myself at the moment. This would be the best solution as then all rewrapping and indentation is handled by clap.

[Diggsey]

Let's do this for now, we can always improve it later if we find a better way.

@bors r+

[bors]

📌 Commit 086143e has been approved by Diggsey

[bors]

⌛ Testing commit 086143e with merge 9ac68e9...

[bors]

💔 Test failed - status-travis

[babbageclunk]

Oh, nice! I guess that was a flaky test?

…

On Sun., 2 Apr. 2017, 21:20 Diggory Blake, ***@***.***> wrote: Merged #1019 <#1019>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1019 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiYx7yRaUcDs9X4k-wOLkky-bo2EwEiks5rr2hHgaJpZM4MuEOP> .

[Diggsey]

Just a network error, yeah.