Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"update not yet available" message should not error #990

Closed
brson opened this issue Mar 16, 2017 · 4 comments
Closed

"update not yet available" message should not error #990

brson opened this issue Mar 16, 2017 · 4 comments
Labels
bug E-easy help wanted

Comments

@brson
Copy link
Contributor

brson commented Mar 16, 2017 

brian@DESKTOP-CODN6ST MINGW64 /c/Users/brian/Documents/dev/taskcluster-crater/rs
$ rustup update stable
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: update not yet available, sorry! try again later
error: checksum failed, expected: '6a73d4aa8eccdfe03fdd7ddd84685c8ccba3ca6516db0475197ef40a21686a52', calculated: '4cf9a1a74dd0d5fdf0b0fabf473e8940f759093b3a1f11c8cef7a9f554d99c5b'

The whole point of the "update not yet available" is to mask the spurious error!
@brson brson added the bug label Mar 16, 2017
@brson brson mentioned this issue Mar 16, 2017
Closed
@brson
Copy link
Contributor Author

brson commented Mar 17, 2017

The thing to do here is locate this code path and make it exit successfully instead of error.

@brson brson added the E-easy label Mar 17, 2017
@alisha17
Copy link

Can I take up this issue ?

@brson
Copy link
Contributor Author

brson commented Mar 20, 2017

@alisha17 Yes you may!

@brson
Copy link
Contributor Author

brson commented May 11, 2017

This work item is still available.

@crazymerlyn crazymerlyn mentioned this issue May 15, 2017
Merged
bors added a commit that referenced this issue May 18, 2017
@bors
Auto merge of #1120 - crazymerlyn:checksum_fail_is_ok, r=Diggsey
1434889 
Exit successfully on "update not yet available"

Fixes #990.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug E-easy help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @alisha17