Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress bar for "installing component" step #1557

Closed
johnthagen opened this issue Dec 1, 2018 · 1 comment
Closed

Add progress bar for "installing component" step #1557

johnthagen opened this issue Dec 1, 2018 · 1 comment

Comments

@johnthagen
Copy link
Contributor

johnthagen commented Dec 1, 2018 •
edited
Loading

Some components, such as rust-docs and rust-src take a bit longer to install, even on SSD-equipped machines. These take even longer on Windows (#1540).

One thing that would help in these situations would be if the user could see the progress of the component install to:

  1. Get a sense for how long the component will take to finish installing
  2. Know that rustup isn't just hung up

Perhaps Cargo's new progress bar released in stable 1.30 could be reused in some way?

...
info: installing component 'rust-docs'
Installing [============>                                           ] 330/1400
@johnthagen johnthagen mentioned this issue Dec 15, 2018
Closed
@johnthagen
Copy link
Contributor Author

At least one user reported thinking that rustup was stuck when it got to installing rust-docs: #1458 (comment)

kinnison added a commit to kinnison/rustup that referenced this issue Dec 27, 2018
@kinnison
rustup-dist: Use Download notifications to track install
ef14a81 
People have requested some indication of progress for long-running
install steps.  This commit re-uses the download tracker logic to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1458, rust-lang#1557
@kinnison kinnison mentioned this issue Dec 27, 2018
Merged
kinnison added a commit to kinnison/rustup that referenced this issue Dec 27, 2018
@kinnison
rustup-dist: Use Download notifications to track install
77cbe9f 
People have requested some indication of progress for long-running
install steps.  This commit re-uses the download tracker logic to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557
kinnison added a commit to kinnison/rustup that referenced this issue Jan 8, 2019
@kinnison
rustup-dist: Use Download notifications to track install
33d6a8c 
People have requested some indication of progress for long-running
install steps.  This commit re-uses the download tracker logic to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557
kinnison added a commit to kinnison/rustup that referenced this issue Jan 13, 2019
@kinnison
rustup-dist: Use Download notifications to track install
771c120 
People have requested some indication of progress for long-running
install steps.  This commit re-uses the download tracker logic to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557
kinnison added a commit to kinnison/rustup that referenced this issue Jan 14, 2019
@kinnison
rustup-dist: Use Download notifications to track install
66336e5 
People have requested some indication of progress for long-running
install steps.  This commit uses the new FileReaderWithProgress to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557

Signed-off-by: Daniel Silverstone <[email protected]>
kinnison added a commit to kinnison/rustup that referenced this issue Jan 14, 2019
@kinnison
rustup-dist: Use Download notifications to track install
c8d7c8e 
People have requested some indication of progress for long-running
install steps.  This commit uses the new FileReaderWithProgress to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557

Signed-off-by: Daniel Silverstone <[email protected]>
kinnison added a commit to kinnison/rustup that referenced this issue Jan 14, 2019
@kinnison
rustup-dist: Use Download notifications to track install
aaead82 
People have requested some indication of progress for long-running
install steps.  This commit uses the new FileReaderWithProgress to
provide a progress bar (the length is the compressed component
tarball but should be good enough) to provide such feedback.

Fixes: rust-lang#1557

Signed-off-by: Daniel Silverstone <[email protected]>
@nrc nrc closed this as completed in #1593 Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnthagen