Pass --locked when installing rustfmt in integration tests
#5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was recently an issue where `cargo install` was installing a newer version of a dependency than the one listed in our Cargo.toml. The newer version added deprecation warnings that caused our continuous integration tests to break. As mentioned in the `cargo help install` docs, passing the `--locked` flag should force cargo to use the `Cargo.lock` file included with the repository.
|
Also noticing that this would backport #3889, which looked to solve a similar issue when cargo was pulling in a newer version of |
ytmimi
force-pushed
the
use-cargo-lock-in-integration-tests
branch
from
8371f29 to
1ccbc1c
Compare
|
This is fine and I will merge, but waiting to make sure bors will accept the upstream sync PR in order to avoid any complexity around git tags and releases |
|
Great 😁 I also figured it would be best to wait on the upstream sync. No rush though! |
calebcartwright
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was recently an issue where
cargo installwas installing a newer version of a dependency than the one listed in our Cargo.toml. The newer version added deprecation warnings that caused our continuous integration tests to break.As mentioned in the
cargo help installdocs, passing the--lockedflag should force cargo to use theCargo.lockfile included with the repository.ref: #5384 (comment)