Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 3999 #5290

Closed
wants to merge 3 commits into from
Closed

Backport 3999 #5290

wants to merge 3 commits into from

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Apr 1, 2022

Do not remove comment from an import with a single item (#3999)

@ytmimi
Copy link
Contributor Author

ytmimi commented Apr 4, 2022

I haven't had a chance to check yet, but it's likely that this backport will fix #4708 and #3984

@calebcartwright
Copy link
Member

This has conflicts that will need to be resolved, though may be worth waiting to do so until after some other PRs land given the likely overlap of modified code

topecongiro and others added 3 commits July 20, 2022 23:55
Do not remove comment from an import with a single item
This is fixed by backporting 3999
This is fixed by backporting 3999
@ytmimi
Copy link
Contributor Author

ytmimi commented Jul 21, 2022

Now that we retain the comments this test case from #3984 is giving us some trouble use a::item /* comment */;

use a::item /* comment */; gets formatted as use a::item; /* comment */; Note the extra semicolon after the comment.

@ytmimi ytmimi added the p-low label Jul 27, 2022
@ytmimi ytmimi removed the p-low label Sep 13, 2022
@ytmimi
Copy link
Contributor Author

ytmimi commented Sep 13, 2022

@calebcartwright Do you think it would be best to drop the test cases for #3984 and address that issue in a separate PR or to try and get that sorted out in this PR as well?

@ytmimi
Copy link
Contributor Author

ytmimi commented Aug 31, 2023

The backport was completed by #5853

@ytmimi ytmimi closed this Aug 31, 2023
@ytmimi ytmimi deleted the backport_3999 branch August 31, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants