Sync with rustc_span changes
#4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok these should be all the changes needed (plus updating |
calebcartwright
changed the title
rustc_span changesrustc_span changes
|
@calebcartwright Thanks for reviewing this. I bumped the version to the new nightly but it hasn't been released yet so we'll have to wait a bit for the tests to pass |
Sorry, jumped a little early on this will check back in another few hours once the next nightly drops. Thank you for the PR over here by the way, very helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#83813 made some changes to
SourceMapandRealFileNamewhich need to be reflected here once they land in nightlyCloses - after updating rustfmt submodule - rust-lang/rust#85226