-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement line debuginfo #291
Conversation
44b3ac9
to
ce8046c
Compare
Unfortunately I had done a couple more commits and forgot to push them :( So a bit of duplicated work there. Not sure if you want to go through my changes and see if there is anything you need, or if you want me to just review what you've done. |
There are a few little changes from your branch I want to incorporate in this PR. |
929a338
to
3f247cc
Compare
I think there's two issues here. First, yes, .debug_ relocations are not needed for MachO, but that is already handled in faerie, as discussed before. Of course, it doesn't hurt to omit them here too. Second, MachO relocations use implicit addends, so you need to write the addend instead of the 0. This will apply to other targets too (eg ELF |
…nglists when empty
a5e7643
to
36f6e2f
Compare
I am going to merge. I will try to fix the macOS problems later. |
Thanks for all the great work @philipc! |
cc @philipc because you are the author of a big part of this
cc #166
blocked on gimli-rs/gimli#362