Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-upload build artifacts #1210

Closed
mre opened this issue Dec 2, 2021 · 4 comments
Closed

Re-upload build artifacts #1210

mre opened this issue Dec 2, 2021 · 4 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows

Comments

@mre
Copy link

mre commented Dec 2, 2021

At the moment the artifact upload is disabled in the workflow here:
https://github.com/bjorn3/rustc_codegen_cranelift/blob/5f5a2f262f1d73355c8d782ec65f3774db728a4d/.github/workflows/main.yml#L155-L162
This might be a leftover of the Windows build.
Any chance we can re-enable the upload and trigger a new build? This would greatly help newcomers get started with cranelift as they wouldn't have to compile it on their machines first.

@bjorn3
Copy link
Member

bjorn3 commented Dec 2, 2021

Artifact upload is enabled for linux and macos. Windows support is currently subpar, but I can try enabling artifact uploads for windows.

@bjorn3 bjorn3 added C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows labels Dec 2, 2021
bjorn3 added a commit that referenced this issue Dec 2, 2021
bjorn3 added a commit that referenced this issue Dec 2, 2021
@mre
Copy link
Author

mre commented Dec 2, 2021

Thanks. On that note, would it be feasible to use Github releases for the artifacts in the future? Asking because the binaries from CI expire after a while and can then no longer be downloaded. See here for example, which is the last successful build from a month ago. (Artifacts don't get attached to failing builds.)

@bjorn3 bjorn3 closed this as completed in 39cd136 Dec 2, 2021
@bjorn3
Copy link
Member

bjorn3 commented Dec 2, 2021

I enabled artifact uploads. I had to disable compression as xzip isn't supported by windows tar and bzip2 hangs. I hope to finish rust-lang/rust#81746 soon. This will cause cg_clif to be distributed with rustup, so rustup component add rustc_codegen_cranelift-preview will be enough to install it. Somewhat ironically it is currently stuck on the windows installer failing to find a file though.

@mre
Copy link
Author

mre commented Dec 2, 2021

Thanks a lot!

This will cause cg_clif to be distributed with rustup

Oh wow that would be amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

2 participants