Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requests or suggestions about rebase and fixup contradictory to rust-highfive bot comment #1111

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Remove requests or suggestions about rebase and fixup contradictory to rust-highfive bot comment #1111

merged 3 commits into from
Jun 24, 2021

Commits on Apr 18, 2021

  1. Remove request of rebase to fixup commits to follow recommendation of… 

    … rust-highfive bot

The bot comment: "If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes."
    @jhg
    jhg committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    ff66b08 View commit details
    Browse the repository at this point in the history

  2. Remove suggestions about rebase to fixup or add additional changes re… 

    …quested

To avoid confusion with the recommendation of rust-highfive bot
    @jhg
    jhg committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    2b47fd3 View commit details
    Browse the repository at this point in the history

  3. Revert deletion of tips that does not produce confusion about guideli… 

    …nes to new contributors
    @jhg
    jhg committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    a4e4ddb View commit details
    Browse the repository at this point in the history