Add support for min_const_generics constants
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
reviewed
Oct 7, 2020
| ); | ||
| t_nohash!( | ||
| "_RMCs4fqI2P2rA04_13const_genericINtB0_6SignedKanb_E", | ||
| "<const_generic::Signed<-11>>" |
There was a problem hiding this comment.
For completion's sake mind adding a test for a positive signed number as well?
(also a false and a different char value too?)
varkor
force-pushed
the
min_const_generics
branch
from
9883928
to
8156c2b
Compare
|
👍 thanks! Would you like a publish for this as well? |
|
Actually, there's one other change @eddyb suggested (I forgot to include it in this PR), so I'll make that first: thanks! |
eddyb
reviewed
Oct 21, 2020
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add demangling for
bool, signed integers, andchar.cc @eddyb