Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add map_continue and continue_value combinators to ControlFlow #99454

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add map_continue and continue_value combinators to ControlFlow #99454

merged 1 commit into from
Jul 21, 2022

Conversation

benluelo
Copy link
Contributor

@benluelo benluelo commented Jul 19, 2022 •
edited
Loading

As suggested in this comment: #75744 (comment)

Related tracking issue: #75744

r? @scottmcm

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 19, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @scottmcm (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@scottmcm
Copy link
Member

Thanks for sending the PR! The code looks good.

Would you might squashing the commits, though, for a bit tidier history?

@scottmcm scottmcm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2022
@benluelo
Add map_continue and continue_value combinators to ControlFlow
1993a5f 
Fix type error

Fix continue_value doc comment
@benluelo benluelo force-pushed the control-flow/continue-combinators branch from c961f3b to 1993a5f Compare July 20, 2022 20:32
@benluelo
Copy link
Contributor Author

Rebased and squashed, should be good to go now!

@scottmcm
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 20, 2022

📌 Commit 1993a5f has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 20, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 20, 2022
@matthiaskrgr
Rollup merge of rust-lang#99454 - benluelo:control-flow/continue-comb…
714a3fd 
…inators, r=scottmcm

Add map_continue and continue_value combinators to ControlFlow

As suggested in this comment: rust-lang#75744 (comment)

Related tracking issue: rust-lang#75744

r? `@scottmcm`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 20, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#99454 - benluelo:control-flow/continue-comb…
94e282d 
…inators, r=scottmcm

Add map_continue and continue_value combinators to ControlFlow

As suggested in this comment: rust-lang#75744 (comment)

Related tracking issue: rust-lang#75744

r? ``@scottmcm``
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 21, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 21, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#99454 - benluelo:control-flow/continue-comb…
a943980 
…inators, r=scottmcm

Add map_continue and continue_value combinators to ControlFlow

As suggested in this comment: rust-lang#75744 (comment)

Related tracking issue: rust-lang#75744

r? ```@scottmcm```
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 21, 2022
@Dylan-DPC
Rollup merge of rust-lang#99454 - benluelo:control-flow/continue-comb…
4fe4577 
…inators, r=scottmcm

Add map_continue and continue_value combinators to ControlFlow

As suggested in this comment: rust-lang#75744 (comment)

Related tracking issue: rust-lang#75744

r? ````@scottmcm````
@Dylan-DPC Dylan-DPC mentioned this pull request Jul 21, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 21, 2022
@matthiaskrgr
Rollup merge of rust-lang#99454 - benluelo:control-flow/continue-comb…
eb0a25f 
…inators, r=scottmcm

Add map_continue and continue_value combinators to ControlFlow

As suggested in this comment: rust-lang#75744 (comment)

Related tracking issue: rust-lang#75744

r? `````@scottmcm`````
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 21, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 21, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2022
@bors
Auto merge of rust-lang#99567 - matthiaskrgr:rollup-08hh3r4, r=matthi…
af7ab34 
…askrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#98707 (std: use futex-based locks on Fuchsia)
 - rust-lang#99413 (Add `PhantomData` marker for dropck to `BTreeMap`)
 - rust-lang#99454 (Add map_continue and continue_value combinators to ControlFlow)
 - rust-lang#99523 (Fix the stable version of `AsFd for Arc<T>` and `Box<T>`)
 - rust-lang#99526 (Normalize the arg spans to be within the call span)
 - rust-lang#99528 (couple of clippy::perf fixes)
 - rust-lang#99549 (Add regression test for rust-lang#52304)
 - rust-lang#99552 (Rewrite `orphan_check_trait_ref` to use a `TypeVisitor`)
 - rust-lang#99557 (Edit `rustc_index::vec::IndexVec::pick3_mut` docs)
 - rust-lang#99558 (Fix `remap_constness`)
 - rust-lang#99559 (Remove unused field in ItemKind::KeywordItem)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9610c71 into rust-lang:master Jul 21, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@benluelo @rust-highfive @rustbot @rust-log-analyzer @scottmcm @bors