-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark stabilized intrinsics with rustc_allowed_through_unstable_modules
#99288
Conversation
Fixes rust-lang#99286 PR rust-lang#95956 accidentally made these intrinsics unstable when accessed through the unstable path segment 'std::intrinsics'
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
(rust-highfive has picked a reviewer for you, use r? to override) |
0ba18e4
to
ef8e322
Compare
In that PR there was a crater run and the regressions were identified, but never discussed. |
Oof, ty for catching that, as @SkiFire13 pointed out I reviewed the crater run and identified all of the APIs that needed that attribute and I did the work to add support for that attribute, but when I came back to the PR to finish the last steps I mistakenly remembered having already added those attributes and didn't carefully re-read my own diff 🤦♀️ . |
This is affecting several repositories - can we get this merged today, so that it makes it into the next nightly? |
Oh, of course, thank you for the reminder. For some reason I was thinking this had to be approved by compiler and not libs, feeling bit scatter brained today >_< @bors r+ |
@bors p=5 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (8c1cc82): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Fixes #99286
PR #95956 accidentally made these intrinsics unstable when
accessed through the unstable path segment 'std::intrinsics'