Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[don't merge] see how much time we save when running --stage 1 in CI #99141

Closed
wants to merge 1 commit into from
Closed

[don't merge] see how much time we save when running --stage 1 in CI #99141

wants to merge 1 commit into from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 11, 2022 •
edited
Loading

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2022
@jyn514 jyn514 added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2022
@jyn514
Copy link
Member Author

jyn514 commented Jul 11, 2022

image
oof

@jyn514 jyn514 closed this Jul 11, 2022
@jyn514
Copy link
Member Author

jyn514 commented Jul 11, 2022

oh, that's because it was building stage 2 still https://github.com/rust-lang/rust/runs/7275527206?check_suite_focus=true#step:25:2441

@jyn514 jyn514 reopened this Jul 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jul 13, 2022
@jyn514
Copy link
Member Author

jyn514 commented Jul 13, 2022 •
edited
Loading

Hmm, I've had to ignore an unfortunately high number of tests to make this run with stage 1. fulldeps I expected, but the linkchecker and error-index-generator also are no longer being run (the linkchecker in particular I think is important to keep, since it's easy to break and hard to run locally). Maybe we can find some way to get those to run in stage 1?

@jyn514
Copy link
Member Author

jyn514 commented Jul 14, 2022

something is still wrong, the stage1 build took longer than stage2

@jyn514 jyn514 mentioned this pull request Jul 30, 2022
Merged
@bors
Copy link
Contributor

bors commented Jul 31, 2022

☔ The latest upstream changes (presumably #99529) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 31, 2022
@Dylan-DPC
Copy link
Member

Closing this as inactive after a discussion with the author

@Dylan-DPC Dylan-DPC closed this Dec 10, 2022
@jyn514 jyn514 mentioned this pull request Mar 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jyn514 @rust-highfive @rust-log-analyzer @bors @Dylan-DPC @kennytm @rustbot