Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #99014

Merged
merged 28 commits into from
Jul 7, 2022
Merged

Rollup of 8 pull requests #99014

merged 28 commits into from
Jul 7, 2022

Commits on Jun 3, 2022

  1. Adapt tests to be able to run in miri

    Decrease the Ns of bug loops to a smaller N, which
    makes them a lot faster in miri.
    Noratrieb committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    907ea55 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Remove needless FIXME

    In this case, it seems fine to have the field be the inverse of the
    flag, especially the `enable` vs `disable` terminology is clear.
    camelid committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    4d67f5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8192288 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2d2fd31 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Configuration menu
    Copy the full SHA
    a2799b2 View commit details
    Browse the repository at this point in the history
  2. incr: cache dwarf objects in work products

    Cache DWARF objects alongside object files in work products when those
    exist so that DWARF object files are available for thorin in packed mode
    in incremental scenarios.
    
    Signed-off-by: David Wood <[email protected]>
    davidtwco committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    8371a03 View commit details
    Browse the repository at this point in the history
  3. ssa: remove dwo of metadata and allocator module

    Compiling with `-Csplit-debuginfo=packed` was leaving behind `.dwo`
    files because either the metadata or allocator module contained a DWARF
    object which was not being removed by the
    `maybe_remove_temps_from_module` closure.
    davidtwco committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    fc641f2 View commit details
    Browse the repository at this point in the history
  4. ssa: abort if dwarf packaging fails

    This should have been here from the start... oops. When `thorin` fails
    to package a DWARF package, that should fail compilation.
    davidtwco committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    e106523 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7d205af View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7967152 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8c9a130 View commit details
    Browse the repository at this point in the history
  8. Fix stacked borrows violation in rustc_arena

    There was a problem with storing a `Box<T>` in a struct, where
    the current rules would invalidate the value. this makes it store
    a raw pointer instead, circumventing the aliasing problems.
    Noratrieb committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    211fb66 View commit details
    Browse the repository at this point in the history
  9. Document, that some lint have to be expected on the crate level (RFC …

    …2383)
    
    Examples: NON_ASCII_IDENTS, UNCOMMON_CODEPOINTS, CONFUSABLE_IDENTS, MIXED_SCRIPT_CONFUSABLES
    xFrednet committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    6c6388c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c8b4873 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a2810cd View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Make MIR basic blocks field public

    This makes it possible to mutably borrow different fields of the MIR
    body without resorting to methods like `basic_blocks_local_decls_mut_and_var_debug_info`.
    
    To preserve validity of control flow graph caches in the presence of
    modifications, a new struct `BasicBlocks` wraps together basic blocks
    and control flow graph caches.
    
    The `BasicBlocks` dereferences to `IndexVec<BasicBlock, BasicBlockData>`.
    On the other hand a mutable access requires explicit `as_mut()` call.
    tmiasko committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    c9dd1d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2446b17 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    39d9c1c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dfa6a7c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    17adfeb View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#96856 - DrMeepster:fix_projection_validatio…

    …n, r=Icnr
    
    Fix ProjectionElem validation
    
    `TypeChecker::visit_projection_elem` was not actually being called.
    Dylan-DPC authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    f6bbe28 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#97711 - Nilstrieb:rustc-arena-ub, r=wesleyw…

    …iser
    
    Improve soundness of rustc_arena
    
    Make it runnable in miri by changing the loop iteration count for some tests in miri. Also fix a stacked borrows issue with box.
    Dylan-DPC authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    d63c713 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#98507 - xFrednet:rfc-2383-manual-expectatio…

    …n-magic, r=wesleywiser
    
    Finishing touches for `#[expect]` (RFC 2383)
    
    This PR adds documentation and some functionality to rustc's lint passes, to manually fulfill expectations. This is needed for some lints in Clippy. Hopefully, it should be one of the last things before we can move forward with stabilizing this feature.
    
    As part of this PR, I've also updated `clippy::duplicate_mod` to showcase how this new functionality can be used and to ensure that it works correctly.
    
    ---
    
    changelog: [`duplicate_mod`]: Fixed lint attribute interaction
    
    r? `@wesleywiser`
    
    cc: rust-lang#97660, rust-lang#85549
    
    And I guess that's it. Here have a magical unicorn 🦄
    Dylan-DPC authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    c815fef View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#98692 - camelid:more-fixmes, r=GuillaumeGomez

    rustdoc: Cleanup more FIXMEs
    
    r? `@GuillaumeGomez`
    Dylan-DPC authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    776bb64 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#98901 - davidtwco:split-dwarf-incr-workprod…

    …uct, r=michaelwoerister
    
    incr: cache dwarf objects in work products
    
    Cache DWARF objects alongside object files in work products when those exist so that DWARF object files are available for thorin in packed mode in incremental scenarios.
    
    r? `@michaelwoerister`
    Dylan-DPC authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    ade6d2c View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#98930 - tmiasko:pub-basic-blocks, r=oli-obk

    Make MIR basic blocks field public
    
    This makes it possible to mutably borrow different fields of the MIR
    body without resorting to methods like `basic_blocks_local_decls_mut_and_var_debug_info`.
    
    To preserve validity of control flow graph caches in the presence of
    modifications, a new struct `BasicBlocks` wraps together basic blocks
    and control flow graph caches.
    
    The `BasicBlocks` dereferences to `IndexVec<BasicBlock, BasicBlockData>`.
    On the other hand a mutable access requires explicit `as_mut()` call.
    Dylan-DPC authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    71b3fbd View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#98973 - GuillaumeGomez:inherent-impl-anchor…

    …s, r=notriddle
    
    Remove (unused) inherent impl anchors
    
    This is something `@notriddle` realized a few days ago: we have unused anchors in the DOM.
    
    This PR removes them.
    
    You can test it [here](https://rustdoc.crud.net/imperio/inherent-impl-anchors/foo/index.html).
    
    r? `@notriddle`
    Dylan-DPC authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    f242e29 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#98981 - pierwill:pierwill/dataflow-docs-edi…

    …ts, r=Dylan-DPC
    
     Edit `rustc_mir_dataflow::framework` documentation
    
    Some edits for clarity and consistency.
    Dylan-DPC authored Jul 7, 2022
    Configuration menu
    Copy the full SHA
    6910d84 View commit details
    Browse the repository at this point in the history