Enable raw-dylib for bin crates #98989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
r? rust-lang/compiler |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Thanks for the PR, @dpaoliello! This looks good to me.
I'm asking for some additional documentation below. Other than that, this looks good to go.
michaelwoerister
approved these changes
Jul 22, 2022
|
Thanks, @dpaoliello! |
|
📌 Commit 55118aa501bc31e74996aa7dbd62703202091a98 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
This PR modifies platform-specific run-make tests, which can be quite iffy in CI, so: |
|
⌛ Testing commit 55118aa501bc31e74996aa7dbd62703202091a98 with merge ff37062700ca00a222586134fe66202229a67ea1... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Jul 26, 2022
|
Finished benchmarking commit (daaae25): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
15 tasks
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Aug 24, 2022
…ister Enable raw-dylib for bin crates Fixes rust-lang#93842 When `raw-dylib` is used in a `bin` crate, we need to collect all of the `raw-dylib` functions, generate the import library and add that to the linker command line. I also changed the tests so that 1) the C++ dlls are created after the Rust dlls, thus there is no chance of accidentally using them in the Rust linking process and 2) disabled generating import libraries when building with MSVC.
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2023
…ister Enable raw-dylib for bin crates Fixes rust-lang#93842 When `raw-dylib` is used in a `bin` crate, we need to collect all of the `raw-dylib` functions, generate the import library and add that to the linker command line. I also changed the tests so that 1) the C++ dlls are created after the Rust dlls, thus there is no chance of accidentally using them in the Rust linking process and 2) disabled generating import libraries when building with MSVC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93842
When
raw-dylibis used in abincrate, we need to collect all of theraw-dylibfunctions, generate the import library and add that to the linker command line.I also changed the tests so that 1) the C++ dlls are created after the Rust dlls, thus there is no chance of accidentally using them in the Rust linking process and 2) disabled generating import libraries when building with MSVC.