core::any: replace some generic types with impl Trait

[nrc]

This gives a cleaner API since the caller only specifies the concrete type they usually want to.

r? @yaahc

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[nrc]

@rustbot label +T-libs-api -T-libs

[yaahc]

Did we land a change that makes it so that we can still turbofish functions that have an impl trait arg? I'm surprised this works.

[nrc]

Did we land a change that makes it so that we can still turbofish functions that have an impl trait arg? I'm surprised this works.

Yes, we stabilised the ability to specify generic parameters where impl Trait is also used, but nothing has changed around actually specifying the implicit parameter corresponding to the impl Trait itself.

[yaahc]

Cool, sounds good, thank you for the update!

@bors r+

[bors]

📌 Commit da11ff3 has been approved by yaahc

It is now in the queue for this repository.

[Dylan-DPC]

failed in rollup ci

@bors r-

[nrc]

@Dylan-DPC the rollup seems to have pulled in an old version of the PR which was failing tests, rather than the current version which passes them? Could you r? and rollup please?

[Dylan-DPC]

sure

@bors r=yaahc

[bors]

📌 Commit da11ff3 has been approved by yaahc

It is now in the queue for this repository.

[Dylan-DPC]

@nrc this seems to be happening again better to let it merge on its own

@bors rollup=never

[nrc]

@Dylan-DPC @yaahc could you re-approve this PR please? Bors seems to think it is unapproved

[Dylan-DPC]

@bors r=yaahc

[bors]

📌 Commit 0c72be3 has been approved by yaahc

It is now in the queue for this repository.

[bors]

⌛ Testing commit 0c72be3 with merge db924fdb2f045c62e5fb51a735ff4567e36cbe5f...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job x86_64-apple-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [run-pass-valgrind] src/test/run-pass-valgrind/cleanup-stdin.rs stdout ----

error: compilation failed!
status: signal: 9 (SIGKILL)
command: "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/work/rust/rust/src/test/run-pass-valgrind/cleanup-stdin.rs" "-Zthreads=1" "--target=x86_64-apple-darwin" "-O" "-C" "prefer-dynamic" "-o" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-pass-valgrind/cleanup-stdin/a" "-Crpath" "-Cdebuginfo=0" "-Lnative=/Users/runner/work/rust/rust/build/x86_64-apple-darwin/native/rust-test-helpers" "-L" "/Users/runner/work/rust/rust/build/x86_64-apple-darwin/test/run-pass-valgrind/cleanup-stdin/auxiliary"
stdout: none
stderr: none


failures:
    [run-pass-valgrind] src/test/run-pass-valgrind/cleanup-stdin.rs

[Mark-Simulacrum]

@bors retry apple valgrind signal 9

[bors]

⌛ Testing commit 0c72be3 with merge 8bd12e8...

[bors]

☀️ Test successful - checks-actions
Approved by: yaahc
Pushing 8bd12e8 to master...

[rust-timer]

Finished benchmarking commit (8bd12e8): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: 🎉 relevant improvement found
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	6.2%	6.3%	2
Improvements 🎉 (primary)	-2.9%	-2.9%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-2.9%	-2.9%	1

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩

2. number of relevant changes ↩