Deny float const params even when adt_const_params is enabled
#98907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
compiler-errors
commented
Jul 4, 2022
src/test/ui/const-generics/float-generic.adt_const_params.stderr
Outdated
Show resolved
Hide resolved
oli-obk
reviewed
Jul 5, 2022
src/test/ui/const-generics/float-generic.adt_const_params.stderr
Outdated
Show resolved
Hide resolved
compiler-errors
force-pushed
the
plz-no-float
branch
from
efadc7e to
869abd4
Compare
|
@bors r+ |
|
📌 Commit 869abd42cb0fa45101b37213398abc6ec604f636 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #99054) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
compiler-errors
force-pushed
the
plz-no-float
branch
from
869abd4 to
57326e1
Compare
|
@bors r=oli-obk |
|
📌 Commit 57326e10fb6c5e186ac932fc57f8f9c46695a4ad has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
compiler-errors
force-pushed
the
plz-no-float
branch
from
57326e1 to
a163464
Compare
|
@bors r=oli-obk |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 11, 2022
…-obk Deny float const params even when `adt_const_params` is enabled Supersedes rust-lang#98825 Fixes rust-lang#98813 r? `@oli-obk`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 11, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#98882 (explain doc comments in macros a bit) - rust-lang#98907 (Deny float const params even when `adt_const_params` is enabled) - rust-lang#99091 (Do not mention private types from other crates as impl candidates) - rust-lang#99140 (Implement `SourceMap::is_span_accessible`) - rust-lang#99147 (Mention similarly named associated type even if it's not clearly in supertrait) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #98825
Fixes #98813
r? @oli-obk