Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation: lint fix + more migration #98420

Merged
merged 7 commits into from
Jun 28, 2022
Merged

translation: lint fix + more migration #98420

merged 7 commits into from
Jun 28, 2022

Commits on Jun 27, 2022

  1. lint: fix condition in diagnostic lints 

    Unfortunately, the diagnostic lints are very broken and trigger much
more often than they should. Correct the conditional which checks if the
function call being made is to a diagnostic function so that it returns
in every intended case.

Signed-off-by: David Wood <[email protected]>
    @davidtwco
    davidtwco committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    871c879 View commit details
    Browse the repository at this point in the history

  2. various: add rustc_lint_diagnostics to diag fns 

    The `rustc_lint_diagnostics` attribute is used by the diagnostic
translation/struct migration lints to identify calls where
non-translatable diagnostics or diagnostics outwith impls are being
created. Any function used in creating a diagnostic should be annotated
with this attribute so this commit adds the attribute to many more
functions.

Signed-off-by: David Wood <[email protected]>
    @davidtwco
    davidtwco committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    ae61224 View commit details
    Browse the repository at this point in the history

  3. privacy: port "field is private" diag 

    Signed-off-by: David Wood <[email protected]>
    @davidtwco
    davidtwco committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    be9ebfd View commit details
    Browse the repository at this point in the history

  4. privacy: port "item is private" diag 

    Signed-off-by: David Wood <[email protected]>
    @davidtwco
    davidtwco committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    cb90a4f View commit details
    Browse the repository at this point in the history

  5. privacy: port unnamed "item is private" diag 

    Signed-off-by: David Wood <[email protected]>
    @davidtwco
    davidtwco committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    0557d02 View commit details
    Browse the repository at this point in the history

  6. privacy: port "in public interface" diag 

    Signed-off-by: David Wood <[email protected]>
    @davidtwco
    davidtwco committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    74f3a96 View commit details
    Browse the repository at this point in the history

  7. privacy: deny diagnostic migration lints 

    Signed-off-by: David Wood <[email protected]>
    @davidtwco
    davidtwco committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    15d61d7 View commit details
    Browse the repository at this point in the history