Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #98237

Merged
merged 1 commit into from
Jun 19, 2022
Merged

update Miri #98237

merged 1 commit into from
Jun 19, 2022

Conversation

RalfJung
Copy link
Member

Fixes #98107
r? @ghost Cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jun 18, 2022

📌 Commit 5609c38 has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 18, 2022
@bors
Copy link
Contributor

bors commented Jun 18, 2022

⌛ Testing commit 5609c38 with merge 8e430bf...

@bors
Copy link
Contributor

bors commented Jun 19, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 8e430bf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 19, 2022
@bors bors merged commit 8e430bf into rust-lang:master Jun 19, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 19, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #98237!

Tested on commit 8e430bf.
Direct link to PR: #98237

🎉 miri on windows: test-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
🎉 miri on linux: test-fail → test-pass (cc @RalfJung @oli-obk @eddyb).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 19, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#98237!
30fab6c 
Tested on commit rust-lang/rust@8e430bf.
Direct link to PR: <rust-lang/rust#98237>

🎉 miri on windows: test-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
🎉 miri on linux: test-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
@bors bors mentioned this pull request Jun 19, 2022
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8e430bf): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 3.2% 3.2% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -1.9% -1.9% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.3% -2.3% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -2.3% -2.3% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@RalfJung RalfJung deleted the miri branch June 21, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#96591
5 participants
@RalfJung @bors @rust-highfive @rust-timer @rustbot