Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: make the Type enum smaller #97929

Closed
wants to merge 1 commit into from
Closed

rustdoc: make the Type enum smaller #97929

wants to merge 1 commit into from

Conversation

notriddle
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Some changes occurred in clean/types.rs.

cc @camelid

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 9, 2022
@rust-highfive
Copy link
Collaborator

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2022
fbstj
fbstj reviewed Jun 9, 2022
View reviewed changes
src/librustdoc/clean/inline.rs
@@ -640,7 +640,7 @@ fn filter_non_trait_generics(trait_did: DefId, mut g: clean::Generics) -> clean:

g.where_predicates.retain(|pred| match pred {
clean::WherePredicate::BoundPredicate {
ty: clean::QPath { self_type: box clean::Generic(ref s), trait_, .. },
ty: clean::QPath(box clean::QPathData { self_type: clean::Generic(ref s), trait_, .. }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

box syntax is being phased out? #97293

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, indeed.

If this shows max-rss improvements, I'll fix this line to use Box::new instead.

@notriddle
Copy link
Contributor Author

@bors try

@rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2022
@bors
Copy link
Contributor

bors commented Jun 9, 2022

⌛ Trying commit 74f9097 with merge cf5590c3574853fadfcaabc248806bb8f5a16955...

@bors
Copy link
Contributor

bors commented Jun 9, 2022

☀️ Try build successful - checks-actions
Build commit: cf5590c3574853fadfcaabc248806bb8f5a16955 (cf5590c3574853fadfcaabc248806bb8f5a16955)

@rust-timer
Copy link
Collaborator

Queued cf5590c3574853fadfcaabc248806bb8f5a16955 with parent d7b8d77, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cf5590c3574853fadfcaabc248806bb8f5a16955): comparison url.

Instruction count

  • Primary benchmarks: mixed results
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 0.6% 0.6% 1
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.7% -0.7% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -0.1% -0.7% 2

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 2.5% 3.0% 2
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -1.0% -1.4% 2
Improvements 🎉
(secondary)		 -1.5% -1.5% 3
All 😿🎉 (primary) 0.7% 3.0% 4

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.8% -2.8% 1
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2022
@notriddle
Copy link
Contributor Author

Is there something I'm missing? It shouldn't be possible for this to affect anything but doc targets, right?

image

@notriddle
Copy link
Contributor Author

However, this isn't a big enough improvement to bother right now.

@notriddle notriddle closed this Jun 10, 2022
@notriddle notriddle deleted the notriddle/smaller-type branch August 23, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbstj fbstj fbstj left review comments

Assignees

@jsha jsha

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@notriddle @rust-highfive @rust-timer @bors @fbstj @jsha @rustbot