Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #97548

Merged
merged 14 commits into from
May 30, 2022
Merged

Rollup of 6 pull requests #97548

merged 14 commits into from
May 30, 2022

Commits on May 28, 2022

  1. Configuration menu
    Copy the full SHA
    7230a15 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d75c60f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cdb8e64 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2022

  1. Configuration menu
    Copy the full SHA
    5a4e936 View commit details
    Browse the repository at this point in the history
  2. Re-add help_on_error for download-ci-llvm

    Remove dead code
    
    Missing }
    
    ./x.py fmt
    
    Remove duplicate check
    
    Recursively remove all usage of help_on_error
    binggh committed May 29, 2022
    Configuration menu
    Copy the full SHA
    c0f18f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e25c23 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. Configuration menu
    Copy the full SHA
    eeacb44 View commit details
    Browse the repository at this point in the history
  2. Remove "sys isn't exported yet" phrase

    The oldest occurence is from 9e224c2,
    which is from the pre-1.0 days. In the years since then, std::sys still
    hasn't been exported, and the last attempt was met with strong criticism:
    rust-lang#97151
    
    Thus, removing the "yet" part makes a lot of sense.
    est31 committed May 30, 2022
    Configuration menu
    Copy the full SHA
    6d63d3b View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#97494 - est31:remove_box_alloc_tests, r=Dyl…

    …an-DPC
    
    Use Box::new() instead of box syntax in library tests
    
    The tests inside `library/*` have no reason to use `box` syntax as they have 0 performance relevance. Therefore, we can safely remove them (instead of having to use alternatives like the one in rust-lang#97293).
    Dylan-DPC authored May 30, 2022
    Configuration menu
    Copy the full SHA
    0ed320b View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#97499 - est31:master, r=Dylan-DPC

    Remove "sys isn't exported yet" phrase
    
    The oldest occurence is from 9e224c2,
    which is from the pre-1.0 days. In the years since then, std::sys still
    hasn't been exported, and the last attempt was met with strong criticism:
    rust-lang#97151
    
    Thus, removing the "yet" part makes a lot of sense.
    Dylan-DPC authored May 30, 2022
    Configuration menu
    Copy the full SHA
    8fd9e24 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#97504 - JohnTitor:cleanup-deps, r=davidtwco

    Ensure source file present when calculating max line number
    
    Resubmission of rust-lang#89268, fixes rust-lang#71363
    The behavior difference of `simulate-remapped-rust-src-base` is not something we should take into account here, so limiting targets to run the test makes sense, I think.
    
    r? `@davidtwco,` and `@estebank,` you might be interested in this change
    Dylan-DPC authored May 30, 2022
    Configuration menu
    Copy the full SHA
    106d5fd View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#97519 - binggh:readd-help-on-error, r=jyn514

    Re-add help_on_error for download-ci-llvm
    
    Closes rust-lang#97503
    
    - Re-added `help_on_error` for `download_component()` and the downstream functions
    - Removed dead code in `bootstrap.py`
    
    Thanks `@jyn514` for the helpful tips!
    
    (first contribution here, please let me know if I missed anything out!)
    Dylan-DPC authored May 30, 2022
    Configuration menu
    Copy the full SHA
    9bb3832 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#97531 - compiler-errors:for-loop-pat-mismat…

    …ch, r=davidtwco
    
    Note pattern mismatch coming from `for` loop desugaring
    
    Fixes rust-lang#97163
    Dylan-DPC authored May 30, 2022
    Configuration menu
    Copy the full SHA
    65bdfe3 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#97545 - thomcc:sip-comment-safety, r=Dylan-DPC

    Reword safety comments in core/hash/sip.rs
    
    In https://rust-lang.zulipchat.com/#narrow/stream/136281-t-lang.2Fwg-unsafe-code-guidelines/topic/Is.20there.20any.20way.20to.20soundly.20do.20a.20masked.20out-of-bounds.20read.3F/near/284329248 it came up that this is using an atypical (and somewhat vague) phrasing of the safety requirement, so this slightly rewords it.
    Dylan-DPC authored May 30, 2022
    Configuration menu
    Copy the full SHA
    a352ad5 View commit details
    Browse the repository at this point in the history