-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use 128 cache align for aarch64 #97414
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
PTAL @Mark-Simulacrum |
Based on some relatively quick searching online, it seems like a 128 cache line size is fairly common on other aarch64 implementations, so it probably makes some sense for us to just gate on aarch64, rather than macOS and aarch64 here. Ultimately this is just for performance (and mostly on parallel-compiler, which isn't enabled by default and isn't on a clear path to being enabled), so getting it wrong is not likely to be terribly important in practice. r=me with this made more general to affect all aarch64. |
Hi, @Mark-Simulacrum , why does it mostly affect on parallel-compiler? it's |
@rustbot label -S-waiting-on-author +S-waiting-on-review |
Oh, well, I probably just misread. Regardless this seems okay now, thanks! @bors r+ rollup=never |
📌 Commit 1446bce has been approved by |
⌛ Testing commit 1446bce with merge 12ebf275fe69e41584ff2cbf8aff8a0297572bcb... |
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors retry msvc access denied in rustdoc tests Seems likely to be spurious. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (fb19760): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
the cache line size of m1 mac is 128.
so use
align(128)
for m1 machere is
sysctl -a hw machdep.cpu
output on m1 mac