Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various refactors to the incr comp workproduct handling #97058

Merged
merged 5 commits into from
Jun 7, 2022
Merged

Various refactors to the incr comp workproduct handling #97058

merged 5 commits into from
Jun 7, 2022

Commits on Jun 6, 2022

  1. Remove unnecessary cgu name length hash 

    This is a tiny optimization
    @bjorn3
    bjorn3 committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    85136db View commit details
    Browse the repository at this point in the history

  2. Rename CodegenUnit::work_product to previous_work_product 

    It returns the previous work product or panics if there is none. This rename
makes the purpose of this method clearer.
    @bjorn3
    bjorn3 committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    02162c4 View commit details
    Browse the repository at this point in the history

  3. Avoid an unnecessary clone for copy_cgu_workproduct_to_incr_comp_cach… 

    …e_dir calls
    @bjorn3
    bjorn3 committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    065e202 View commit details
    Browse the repository at this point in the history

  4. Factor Option out of copy_cgu_workproduct_to_incr_comp_cache_dir call 

    This improves clarity of the code a bit
    @bjorn3
    bjorn3 committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    906b851 View commit details
    Browse the repository at this point in the history

  5. Make saved_file field of WorkProduct non-optional 

    A WorkProduct without a saved file is useless
    @bjorn3
    bjorn3 committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    e16c3b4 View commit details
    Browse the repository at this point in the history