Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move check-bootstrap from a makefile rule to test::Bootstrap #96689

Merged
merged 1 commit into from
May 8, 2022
Merged

Move check-bootstrap from a makefile rule to test::Bootstrap #96689

merged 1 commit into from
May 8, 2022

Conversation

gimbling-away
Copy link
Contributor

Fixes #96688

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@gimbling-away gimbling-away marked this pull request as draft May 4, 2022 04:03
@gimbling-away gimbling-away marked this pull request as ready for review May 4, 2022 04:44
@gimbling-away
Copy link
Contributor Author

(Force push was a squash)

bjorn3
bjorn3 reviewed May 4, 2022
View reviewed changes
src/bootstrap/test.rs Outdated Show resolved Hide resolved
bjorn3
bjorn3 reviewed May 4, 2022
View reviewed changes
src/bootstrap/test.rs Outdated Show resolved Hide resolved
@gimbling-away
Copy link
Contributor Author

I..have to say, you're really quick at reviewing these, I just committed 😂

@rust-log-analyzer

This comment has been minimized.

Sign in to view
jyn514
jyn514 approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with CI passing :) thanks for working on this!

@Mark-Simulacrum
Copy link
Member

r=me with commits squashed

@gimbling-away
Copy link
Contributor Author

@Mark-Simulacrum Squashed 👍🏻

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 7, 2022

📌 Commit 72d2d6a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2022
@bors
Copy link
Contributor

bors commented May 8, 2022

⌛ Testing commit 72d2d6a with merge 8fbd92d...

@bors
Copy link
Contributor

bors commented May 8, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 8fbd92d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 8, 2022
@bors bors merged commit 8fbd92d into rust-lang:master May 8, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 8, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8fbd92d): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@gimbling-away gimbling-away deleted the campfire branch May 10, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@jyn514 jyn514 jyn514 approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

Move check-bootstrap from a makefile rule to test::Bootstrap
9 participants
@gimbling-away @rust-highfive @rust-log-analyzer @Mark-Simulacrum @bors @rust-timer @bjorn3 @jyn514 @rustbot