-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline core::panic::Location methods #96348
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
For caller this was tried previously and had to be reverted, see #95735 |
@the8472 Isn't that a bug in |
I'm just pointing out the issue, I'm no cranelift expert. But cranelift is an official, although experimental, compiler backend so libcore has to work with it too. |
Looks like the implementation of |
That was indeed the issue. Pushed bjorn3/rustc_codegen_cranelift@f3fc94f with a fix. Adding |
By the way feel free to ping me about anything regarding the cranelift backend. |
Great, thanks for clarifying @bjorn3. Do you have the ability to merge this PR? |
Technically I can approve it. However I don't feel qualified to review non-compiler changes. |
The rationale from the previously approved PR should still apply. It's not an API change. And @bjorn3 fixed the reason for the revert. So this should be fine. Disabling rollup since the queue is almost empty and this changes a few more methods to inline, compared to the previous PR. @bors r+ rollup=never |
📌 Commit 92a5841 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (579d268): comparison url. Summary:
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Footnotes |
The inlining here only changes function calls to register loads, so this seems spurious. https://godbolt.org/z/41YhbWfEr @rustbot label: +perf-regression-triaged |
This avoids the overhead of a function call when used.