Remove a few uses of @-pointers for @ast::Expr and @mut Block in trans #9630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 30, 2013 19:37
Use borrowed references in a few locations that were encountered when working on other changes.
Use &mut Block and &Block references where possible in the builder functions in trans::build. @mut Block remains in a few functions where I could not (not yet at least) track down the runtime borrowck failures.
|
Rebased (no changes but author dates) and reopened version of PR #9615 |
bors
added a commit
that referenced
this pull request
Sep 30, 2013
This is mostly an incremental change, picking off some uses of @- or @mut-pointers that can be replaced by references. Almost all of the builder functions in trans::build are updated, mostly using `&Block` arguments instead of `@mut Block`.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 21, 2022
Fix allow_attributes_without_reason applying to external crate macros Previously the `clippy::allow_attributes_without_reason` lint would apply to external crate macros. Many macros in the Rust ecosystem include these `allow` attributes without adding a reason, making this lint pretty much unusable in any sizable Rust project. This commit fixes that by adding a check to the lint if the attribute is from an external crate macro and returning early. ``` changelog: [`allow_attributes_without_reason`]: allow_attributes_without_reason no longer applies to external crate macros ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly an incremental change, picking off some uses of
@- or @mut-pointers that can be replaced by references.
Almost all of the builder functions in trans::build are updated,
mostly using
&Blockarguments instead of@mut Block.