Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Reduce allocations in a html::markdown function #95868

Merged
merged 1 commit into from
Apr 10, 2022
Merged

rustdoc: Reduce allocations in a html::markdown function #95868

merged 1 commit into from
Apr 10, 2022

Conversation

vacuus
Copy link
Contributor

@vacuus vacuus commented Apr 9, 2022

No description provided.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 9, 2022
@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2022
@GuillaumeGomez
Copy link
Member

Thanks! Let's check what the perf run says about it.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 10, 2022
@bors
Copy link
Contributor

bors commented Apr 10, 2022

⌛ Trying commit 8e15b6c with merge 992769f7e91af5bdaaf425c07df6d056bf5e2771...

@bors
Copy link
Contributor

bors commented Apr 10, 2022

☀️ Try build successful - checks-actions
Build commit: 992769f7e91af5bdaaf425c07df6d056bf5e2771 (992769f7e91af5bdaaf425c07df6d056bf5e2771)

@rust-timer
Copy link
Collaborator

Queued 992769f7e91af5bdaaf425c07df6d056bf5e2771 with parent 341883d, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (992769f7e91af5bdaaf425c07df6d056bf5e2771): comparison url.

Summary:

  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 1 0 0 0 1
mean2 0.5% N/A N/A N/A 0.5%
max 0.5% N/A N/A N/A 0.5%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 10, 2022
@GuillaumeGomez
Copy link
Member

No relevant changes apparently so I guess it's good to go.

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Apr 10, 2022

📌 Commit 8e15b6c has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 10, 2022
Merged
@klensy
Copy link
Contributor

klensy commented Apr 10, 2022

No relevant changes apparently so I guess it's good to go.

It's actually more green, if you filter by doc builds and check Show non-relevant results

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2022
@bors
Auto merge of rust-lang#95889 - Dylan-DPC:rollup-1cmywu4, r=Dylan-DPC
1f7fb64 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#95566 (Avoid duplication of doc comments in `std::char` constants and functions)
 - rust-lang#95784 (Suggest replacing `typeof(...)` with an actual type)
 - rust-lang#95807 (Suggest adding a local for vector to fix borrowck errors)
 - rust-lang#95849 (Check for git submodules in non-git source tree.)
 - rust-lang#95852 (Fix missing space in lossy provenance cast lint)
 - rust-lang#95857 (Allow multiple derefs to be splitted in deref_separator)
 - rust-lang#95868 (rustdoc: Reduce allocations in a `html::markdown` function)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fcfecab into rust-lang:master Apr 10, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 10, 2022
@vacuus vacuus deleted the markdown-code-blocks branch April 21, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
7 participants
@vacuus @rust-highfive @GuillaumeGomez @rust-timer @bors @klensy @rustbot