Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix perf issue for auto trait selection #95333

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Fix perf issue for auto trait selection #95333

merged 2 commits into from
Mar 28, 2022

Conversation

GuillaumeGomez
Copy link
Member

Follow-up of #95069 which fixes the perf issue introduced by it.

r? @oli-obk

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 26, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2022
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 26, 2022
@GuillaumeGomez
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 26, 2022
@bors
Copy link
Contributor

bors commented Mar 26, 2022

⌛ Trying commit ad88732 with merge 9db3bca9e8b8c644abfdd58ef3114d02f9f7e03b...

@bors
Copy link
Contributor

bors commented Mar 26, 2022

☀️ Try build successful - checks-actions
Build commit: 9db3bca9e8b8c644abfdd58ef3114d02f9f7e03b (9db3bca9e8b8c644abfdd58ef3114d02f9f7e03b)

@rust-timer
Copy link
Collaborator

Queued 9db3bca9e8b8c644abfdd58ef3114d02f9f7e03b with parent bc881e8, future comparison URL.

@GuillaumeGomez
Copy link
Member Author

Let's run another perf check to see if there is any difference with one field removed.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Mar 27, 2022

⌛ Trying commit bd51f17 with merge 00ed864234397653296be8e49cfa858c092ccd63...

@bors
Copy link
Contributor

bors commented Mar 27, 2022

☀️ Try build successful - checks-actions
Build commit: 00ed864234397653296be8e49cfa858c092ccd63 (00ed864234397653296be8e49cfa858c092ccd63)

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9db3bca9e8b8c644abfdd58ef3114d02f9f7e03b): comparison url.

Summary: This benchmark run shows 22 relevant improvements 🎉 to instruction counts.

  • Arithmetic mean of relevant improvements: -2.9%
  • Largest improvement in instruction counts: -10.2% on full builds of cargo-0.60.0 doc

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 27, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Mar 27, 2022

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Mar 27, 2022

📌 Commit bd51f17 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2022
@bors
Copy link
Contributor

bors commented Mar 28, 2022

⌛ Testing commit bd51f17 with merge 3badf5c...

@bors
Copy link
Contributor

bors commented Mar 28, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 3badf5c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 28, 2022
@bors bors merged commit 3badf5c into rust-lang:master Mar 28, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 28, 2022
@bors bors mentioned this pull request Mar 28, 2022
Closed
@GuillaumeGomez GuillaumeGomez deleted the auto-trait-perf-issue branch March 28, 2022 08:24
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3badf5c): comparison url.

Summary: This benchmark run shows 20 relevant improvements 🎉 to instruction counts.

  • Arithmetic mean of relevant improvements: -3.1%
  • Largest improvement in instruction counts: -10.1% on full builds of cargo-0.60.0 doc

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@Alexendoo Alexendoo mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rust-timer @bors @oli-obk @rust-highfive @rustbot