Reapply: Mark drop calls in landing pads cold instead of noinline #94823
Conversation
rustbot
added
the
T-compiler
erikdesjardins
force-pushed
the
re-cold-land
branch
from
492d746
to
5266aa7
Compare
|
@bors try |
|
⌛ Trying commit 5266aa7 with merge ccd5064a169a0c1748c8555e905f9055884e0507... |
|
☀️ Try build successful - checks-actions |
|
@erikdesjardins any updates on this? |
|
While I concur with nikic's analysis here (#94390 (comment)), I still doubt this will be accepted without further LLVM changes. I guess draft PRs aren't excluded from triage? |
rustbot
added
the
S-blocked
|
@erikdesjardins Hi. Noticable size bloat(about 2%) and codegen degradation happened on our private project after upgrading rustc. After bisection, I found that the problem was introduced in #94402, which could be resolved by this PR. I tested locally and found that this PR will fix not only #46515, #87055, but also #97217 and #98679. As the compile time issue was trimmed(#94390 (comment)), could you push this PR forward? |
|
I would also like to see this relanded, but I still agree with my previous comment, so I'm not going to spend the time to update this PR. You have my blessing to rebase these commits and open your own PR if you want. |
@erikdesjardins @ldm0 Since there didn't seem to be any activity on this, I took the liberty of rebasing this off master and opening a rebased PR. Let me know how I can help to move this along. |
|
Closing this in favour of #102099 |
Dylan-DPC
removed
the
S-blocked
…=nikic Rebased: Mark drop calls in landing pads cold instead of noinline I noticed that certain inlining optimizations were missing while staring at some compiled code output. I'd like to see this relanded, so I rebased the PR from ``@erikdesjardins`` (PR rust-lang#94823). This PR reapplies rust-lang#92419, which was reverted in rust-lang#94402 due to rust-lang#94390. Fixes rust-lang#46515, fixes rust-lang#87055. Update: fixes rust-lang#97217.
…ikic Rebased: Mark drop calls in landing pads cold instead of noinline I noticed that certain inlining optimizations were missing while staring at some compiled code output. I'd like to see this relanded, so I rebased the PR from `@erikdesjardins` (PR rust-lang#94823). This PR reapplies rust-lang#92419, which was reverted in rust-lang#94402 due to rust-lang#94390. Fixes rust-lang#46515, fixes rust-lang#87055. Update: fixes rust-lang#97217.
…ikic Rebased: Mark drop calls in landing pads cold instead of noinline I noticed that certain inlining optimizations were missing while staring at some compiled code output. I'd like to see this relanded, so I rebased the PR from `@erikdesjardins` (PR rust-lang#94823). This PR reapplies rust-lang#92419, which was reverted in rust-lang#94402 due to rust-lang#94390. Fixes rust-lang#46515, fixes rust-lang#87055. Update: fixes rust-lang#97217.
…ikic Rebased: Mark drop calls in landing pads cold instead of noinline I noticed that certain inlining optimizations were missing while staring at some compiled code output. I'd like to see this relanded, so I rebased the PR from `@erikdesjardins` (PR rust-lang#94823). This PR reapplies rust-lang#92419, which was reverted in rust-lang#94402 due to rust-lang#94390. Fixes rust-lang#46515, fixes rust-lang#87055. Update: fixes rust-lang#97217.
Reapplies #92419, which was reverted in #94402 due to #94390.
Fixes #46515, fixes #87055.
r? @ghost