Clean up the std library's #![feature]s #94546
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@rustbot label C-cleanup, T-libs |
rustbot
added
C-cleanup
JmPotato
force-pushed
the
std-features-cleanup
branch
2 times, most recently
from
f305e6f
to
d2dc6fc
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #94548) made this pull request unmergeable. Please resolve the merge conflicts. |
JmPotato
force-pushed
the
std-features-cleanup
branch
from
a38c4cc
to
afd996a
Compare
JmPotato
force-pushed
the
std-features-cleanup
branch
from
afd996a
to
42cb2ea
Compare
Done. Thx for your review! |
|
@bors r+ |
|
📌 Commit 42cb2ea has been approved by |
bors
added
S-waiting-on-bors
…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `@m-ou-se`
…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? ``@m-ou-se``
…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? ```@m-ou-se```
…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? ````@m-ou-se````
…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `````@m-ou-se`````
…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `@m-ou-se`
…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? ``@m-ou-se``
…ou-se Clean up the std library's #![feature]s Signed-off-by: JmPotato <[email protected]> This is part of rust-lang#87766. r? `@m-ou-se`
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
std-features-cleanup
branch
from
42cb2ea
to
9b952b7
Compare
@Dylan-DPC Hello, I just fixed the missing |
|
no worries, i'll r+ it and then it will either get merged individually or included in a rollup later today |
Maybe an individual merge is proper since the deleted |
|
@bors r=m-ou-se |
|
📌 Commit 9b952b7 has been approved by |
|
@bors rollup=never |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (86067bb): comparison url. Summary: This benchmark run did not return any relevant results. 4 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
…, r=Dylan-DPC Reverted atomic_mut_ptr feature removal causing compilation break Fixes a regression introduced as part of rust-lang#94546 Std no longer compiles on nightly while using the following commnd: export RUSTFLAGS='-C target-feature=+atomics,+bulk-memory' cargo build --target wasm32-unknown-unknown -Z build-std=panic_abort,std I can help add tests to avoid future breaks but i couldn't understand the test framework
Signed-off-by: JmPotato [email protected]
This is part of #87766.
r? @m-ou-se