Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[generator_interior] Be more precise with scopes of borrowed places #94309

Merged
merged 8 commits into from
Mar 18, 2022
Merged

[generator_interior] Be more precise with scopes of borrowed places #94309

merged 8 commits into from
Mar 18, 2022

Commits on Mar 7, 2022

  1. try to fix issue 57017, but not quite there yet 

    Co-authored-by: Eric Holk <[email protected]>
    @nikomatsakis @eholk
    nikomatsakis and eholk committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    60f5cad View commit details
    Browse the repository at this point in the history

  2. Move test to right place

    @eholk
    eholk committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    513a9c6 View commit details
    Browse the repository at this point in the history

  3. Trying to detect autorefs to avoid unnecessary borrowed temporaries 

    This is all almost certainly wrong
    @eholk
    eholk committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    ac804f2 View commit details
    Browse the repository at this point in the history

  4. Distinguish borrows of copies from other borrows

    @eholk
    eholk committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    87ad668 View commit details
    Browse the repository at this point in the history

  5. Update clippy to new ExprUseVisitor delegate

    @eholk
    eholk committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    9f0f46f View commit details
    Browse the repository at this point in the history

  6. Add comments based on code review feedback

    @eholk
    eholk committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    170b027 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Use projections rather than is_autoref 

    Also includes a lengthy comment arguing the correctness.

Co-authored-by: Niko Matsakis <[email protected]>
    @eholk @nikomatsakis
    eholk and nikomatsakis committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    12d8ca1 View commit details
    Browse the repository at this point in the history

  2. Remove is_autoref parameter

    @eholk
    eholk committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    2fcd542 View commit details
    Browse the repository at this point in the history