Fix links in std:: and extra:: documentation #9424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is such a common occurrence that I would rather fix this at the source. Pandoc has an extension called |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 23, 2013
@bytbox in rust-lang#9424 found out that http://foo.com wasn't rendered as a link in pandoc by default. This extension to pandoc enables the auto-linking behaviour, however.
|
Ok; sounds good. Where possible, would we rather have link text instead of a bare URI-link preceded by "see"? I.e., is 6c7bbd a good type of change to make? |
|
I don't really mind either way, I'm fine with stylistically preferring "See" in front, while not requiring it. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 9, 2022
Fix `unnecessary_to_owned` false positive Fixes rust-lang#9351. Note that this commit reworks that fix for rust-lang#9317. The change is to check that the type implements `AsRef<str>` before regarding `to_string` as an equivalent of `to_owned`. This was suggested by Jarcho in the rust-lang#9317 issue comments. The benefit of this is that it moves some complexity out of `check_other_call_arg` and simplifies the module as a whole. changelog: FP: [`unnecessary_to_owned`]: No longer lints, if type change would cause errors in the caller function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown does not recognize links that don't use link syntax (either brackets+parens or angular brackets). All links in doc comments are fixed in these commits.