Convert newtype_index to a proc macro
#93878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
nnethercote
reviewed
Feb 10, 2022
| /// | ||
| /// - The `From` impls are the preferred way. So you can do | ||
| /// `S::from(v)` with a `usize` or `u32`. And you can convert back | ||
| /// to an integer with `u32::from(s)`. |
There was a problem hiding this comment.
I know this comment is pre-existing, but while we're here: is this advice correct? I personally prefer S::new(v) and s.index(), and I feel like I've seen those forms more often.
There was a problem hiding this comment.
I'm not sure - I think this could be dealt with in a follow-up issue, since it's just a style reccomendation.
jackh726
added
S-waiting-on-author
Aaron1011
force-pushed
the
newtype-macro
branch
from
346e2a2
to
3f95400
Compare
cjgillot
reviewed
Feb 18, 2022
Aaron1011
force-pushed
the
newtype-macro
branch
from
3f95400
to
cb2e4ee
Compare
|
@cjgillot I've addressed your comments |
|
📌 Commit cb2e4ee has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2022
Convert `newtype_index` to a proc macro The `macro_rules!` implementation was becomng excessively complicated, and difficult to modify. The new proc macro implementation should make it much easier to add new features (e.g. skipping certain `#[derive]`s)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2022
Convert `newtype_index` to a proc macro The `macro_rules!` implementation was becomng excessively complicated, and difficult to modify. The new proc macro implementation should make it much easier to add new features (e.g. skipping certain `#[derive]`s)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2022
Convert `newtype_index` to a proc macro The `macro_rules!` implementation was becomng excessively complicated, and difficult to modify. The new proc macro implementation should make it much easier to add new features (e.g. skipping certain `#[derive]`s)
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 19, 2022
Convert `newtype_index` to a proc macro The `macro_rules!` implementation was becomng excessively complicated, and difficult to modify. The new proc macro implementation should make it much easier to add new features (e.g. skipping certain `#[derive]`s)
|
might be reponsible for these ci failures: #94167 (comment) |
|
⌛ Testing commit cb2e4ee with merge 0525b7fa548f72c821ac5997db8da88ca7b685e9... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #93984) made this pull request unmergeable. Please resolve the merge conflicts. |
The `macro_rules!` implementation was becomng excessively complicated, and difficult to modify. The new proc macro implementation should make it much easier to add new features (e.g. skipping certain `#[derive]`s)
These links never worked, but the lint was suppressed due to the fact that the span was pointing into the macro. With the new macro implementation, the span now points directly to the doc comment in the macro invocation, so it's no longer suppressed.
Aaron1011
force-pushed
the
newtype-macro
branch
from
cb2e4ee
to
7b7b0f1
Compare
|
@bors r=cjgillot |
|
📌 Commit 7b7b0f1 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (f6a7993): comparison url. Summary: This benchmark run shows 4 relevant improvements 🎉 to instruction counts.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
macro_rules!implementation was becomng excessively complicated,and difficult to modify. The new proc macro implementation should make
it much easier to add new features (e.g. skipping certain
#[derive]s)