Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build libcore as 2021 in a few more places #93719

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

scottmcm
Copy link
Member

@scottmcm scottmcm commented Feb 6, 2022

The Cargo.toml has edition = "2021" (as of #92068), so that's what these command lines should use too.

The `Cargo.toml` has `edition = "2021"`, so that's what these command lines should use too.
@rust-highfive
Copy link
Collaborator

r? @pietroalbini

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2022
@scottmcm
Copy link
Member Author

scottmcm commented Feb 6, 2022

r? @Mark-Simulacrum
@bors rollup=iffy

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never since this touches pgo scripts

@bors
Copy link
Contributor

bors commented Feb 7, 2022

📌 Commit d91e7a3 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2022
@bors
Copy link
Contributor

bors commented Feb 7, 2022

⌛ Testing commit d91e7a3 with merge c5e4148...

@bors
Copy link
Contributor

bors commented Feb 7, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing c5e4148 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 7, 2022
@bors bors merged commit c5e4148 into rust-lang:master Feb 7, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 7, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c5e4148): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants