Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashing for windows paths containing a CurDir component #93697

Merged
merged 2 commits into from
Feb 12, 2022

Commits on Feb 6, 2022

  1. Fix hashing for windows paths containing a CurDir component

    * the logic only checked for / but not for \
    * verbatim paths shouldn't skip items at all since they don't get normalized
    * the extra branches get optimized out on unix since is_sep_byte is a trivial comparison and is_verbatim is always-false
    * tests lacked windows coverage for these cases
    
    That lead to equal paths not having equal hashes and to unnecessary collisions.
    the8472 committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    45082b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2022

  1. ignore test on wasm32

    A fix applied to std::Path::hash triggers a miscompilation/assert in LLVM in this test on wasm32.
    The miscompilation appears to pre-existing. Reverting some previous changes done std::Path also trigger it
    and slight modifications such as changing the test path from "a" to "ccccccccccc" also make it pass, indicating
    it's very flaky.
    Since the fix is for a higher-tier platform than wasm it takes precedence.
    the8472 committed Feb 12, 2022
    Configuration menu
    Copy the full SHA
    1d21ce7 View commit details
    Browse the repository at this point in the history