-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #93625
Rollup of 5 pull requests #93625
Commits on Jan 1, 2022
-
Stabilize -Z instrument-coverage as -C instrument-coverage
Continue supporting -Z instrument-coverage for compatibility for now, but show a deprecation warning for it. Update uses and documentation to use the -C option. Move the documentation from the unstable book to stable rustc documentation.
Configuration menu - View commit details
-
Copy full SHA for 34106f8 - Browse repository at this point
Copy the full SHA 34106f8View commit details -
Rewrite instrument-coverage documentation to use LLVM tools directly
llvm-tools-preview is still experimental, so document it as such, and don't use it in the examples.
Configuration menu - View commit details
-
Copy full SHA for 760c13f - Browse repository at this point
Copy the full SHA 760c13fView commit details -
Update instrument-coverage documentation to document stability and LL…
…VM versions The instrument-coverage option is stable; the details of the profile data format are not. Recommend llvm-tools-preview as the preferred alternative to obtain a compatible version of the LLVM tools, rather than finding LLVM tools elsewhere.
Configuration menu - View commit details
-
Copy full SHA for c840003 - Browse repository at this point
Copy the full SHA c840003View commit details -
Clarify stability expectations for llvm-tools-preview
Co-authored-by: Mark Rousskov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e14bd48 - Browse repository at this point
Copy the full SHA e14bd48View commit details
Commits on Jan 2, 2022
-
Require
-Zunstable-options
for-C instrument-coverage=except-*
op……tions These options primarily exist to work around bugs, and those bugs have largely been fixed. Avoid stabilizing them, so that we don't have to support them indefinitely.
Configuration menu - View commit details
-
Copy full SHA for 6593fcd - Browse repository at this point
Copy the full SHA 6593fcdView commit details
Commits on Jan 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e1eff1b - Browse repository at this point
Copy the full SHA e1eff1bView commit details
Commits on Feb 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1dbdfc4 - Browse repository at this point
Copy the full SHA 1dbdfc4View commit details -
Add more *-unwind ABI variants
The following *-unwind ABIs are now supported: - "C-unwind" - "cdecl-unwind" - "stdcall-unwind" - "fastcall-unwind" - "vectorcall-unwind" - "thiscall-unwind" - "aapcs-unwind" - "win64-unwind" - "sysv64-unwind" - "system-unwind"
Configuration menu - View commit details
-
Copy full SHA for 547b4e6 - Browse repository at this point
Copy the full SHA 547b4e6View commit details
Commits on Feb 3, 2022
-
The "CI" environment var isn't universal (for example, I think Azure uses TF_BUILD). However, we are mostly concerned with rust-lang/rust's own CI which currently is GitHub Actions which does set "CI". And I think most other providers use "CI" as well.
Configuration menu - View commit details
-
Copy full SHA for c64d6bf - Browse repository at this point
Copy the full SHA c64d6bfView commit details -
Fix ret > 1 bound if shadowed by const
Prior to a change, it would only look at types in bounds. When it started looking for consts, shadowing type variables with a const would cause an ICE, so now defer looking at consts only if there are no types present.
Configuration menu - View commit details
-
Copy full SHA for 2dfd77d - Browse repository at this point
Copy the full SHA 2dfd77dView commit details -
Rollup merge of rust-lang#90132 - joshtriplett:stabilize-instrument-c…
…overage, r=wesleywiser Stabilize `-Z instrument-coverage` as `-C instrument-coverage` (Tracking issue for `instrument-coverage`: rust-lang#79121) This PR stabilizes support for instrumentation-based code coverage, previously provided via the `-Z instrument-coverage` option. (Continue supporting `-Z instrument-coverage` for compatibility for now, but show a deprecation warning for it.) Many, many people have tested this support, and there are numerous reports of it working as expected. Move the documentation from the unstable book to stable rustc documentation. Update uses and documentation to use the `-C` option. Addressing questions raised in the tracking issue: > If/when stabilized, will the compiler flag be updated to -C instrument-coverage? (If so, the -Z variant could also be supported for some time, to ease migrations for existing users and scripts.) This stabilization PR updates the option to `-C` and keeps the `-Z` variant to ease migration. > The Rust coverage implementation depends on (and automatically turns on) -Z symbol-mangling-version=v0. Will stabilizing this feature depend on stabilizing v0 symbol-mangling first? If so, what is the current status and timeline? This stabilization PR depends on rust-lang#90128 , which stabilizes `-C symbol-mangling-version=v0` (but does not change the default symbol-mangling-version). > The Rust coverage implementation implements the latest version of LLVM's Coverage Mapping Format (version 4), which forces a dependency on LLVM 11 or later. A compiler error is generated if attempting to compile with coverage, and using an older version of LLVM. Given that LLVM 13 has now been released, requiring LLVM 11 for coverage support seems like a reasonable requirement. If people don't have at least LLVM 11, nothing else breaks; they just can't use coverage support. Given that coverage support currently requires a nightly compiler and LLVM 11 or newer, allowing it on a stable compiler built with LLVM 11 or newer seems like an improvement. The [tracking issue](rust-lang#79121) and the [issue label A-code-coverage](https://github.com/rust-lang/rust/labels/A-code-coverage) link to a few open issues related to `instrument-coverage`, but none of them seem like showstoppers. All of them seem like improvements and refinements we can make after stabilization. The original `-Z instrument-coverage` support went through a compiler-team MCP at rust-lang/compiler-team#278 . Based on that, ``@pnkfelix`` suggested that this needed a stabilization PR and a compiler-team FCP.
Configuration menu - View commit details
-
Copy full SHA for e7412ea - Browse repository at this point
Copy the full SHA e7412eaView commit details -
Rollup merge of rust-lang#93402 - ehuss:llvm-dialog, r=michaelwoerister
Windows: Disable LLVM crash dialog boxes. This disables the crash dialog box on Windows. When LLVM hits an assertion, it will open a dialog box with Abort/Retry/Ignore. This is annoying on CI because CI will just hang until it times out (which can take hours). Instead of opening a dialog box, it will print a message like this: ``` Assertion failed: isa<X>(Val) && "cast<Ty>() argument of incompatible type!", file D:\Proj\rust\rust\src\llvm-project\llvm\include\llvm/Support/Casting.h, line 255 ``` Closes rust-lang#92829
Configuration menu - View commit details
-
Copy full SHA for 22da463 - Browse repository at this point
Copy the full SHA 22da463View commit details -
Rollup merge of rust-lang#93561 - Amanieu:more-unwind-abi, r=nagisa
Add more *-unwind ABI variants The following *-unwind ABIs are now supported: - "C-unwind" - "cdecl-unwind" - "stdcall-unwind" - "fastcall-unwind" - "vectorcall-unwind" - "thiscall-unwind" - "aapcs-unwind" - "win64-unwind" - "sysv64-unwind" - "system-unwind" cc ``@rust-lang/wg-ffi-unwind``
Configuration menu - View commit details
-
Copy full SHA for 008870c - Browse repository at this point
Copy the full SHA 008870cView commit details -
Rollup merge of rust-lang#93593 - JulianKnodt:master, r=oli-obk
Fix ret > 1 bound if shadowed by const Prior to a change, it would only look at types in bounds. When it started looking for consts, shadowing type variables with a const would cause an ICE, so now defer looking at consts only if there are no types present. cc `@compiler-errors` Should Fix rust-lang#93553
Configuration menu - View commit details
-
Copy full SHA for e1ee8fa - Browse repository at this point
Copy the full SHA e1ee8faView commit details -
Rollup merge of rust-lang#93597 - GuillaumeGomez:update-browser-ui-te…
…st, r=jsha Update browser-ui-test version The puppeteer version update is limited because new versions has some "interesting" flaws. r? ``@jsha``
Configuration menu - View commit details
-
Copy full SHA for 511dca5 - Browse repository at this point
Copy the full SHA 511dca5View commit details