-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable] Fix CVE 2022 21658 and prepare 1.58.1 #93110
Merged
bors
merged 15 commits into
rust-lang:stable
from
pietroalbini:pa-cve-2022-21658-stable
Jan 20, 2022
Merged
[stable] Fix CVE 2022 21658 and prepare 1.58.1 #93110
bors
merged 15 commits into
rust-lang:stable
from
pietroalbini:pa-cve-2022-21658-stable
Jan 20, 2022
Commits on Jan 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b167157 - Browse repository at this point
Copy the full SHA b167157View commit details -
Only check for errors in predicate when skipping impl assembly
Prior to PR rust-lang#91205, checking for errors in the overall obligation would check checking the `ParamEnv`, due to an incorrect `super_visit_with` impl. With this bug fixed, we will now bail out of impl candidate assembly if the `ParamEnv` contains any error types. In practice, this appears to be overly conservative - when an error occurs early in compilation, we end up giving up early for some predicates that we could have successfully evaluated without overflow. By only checking for errors in the predicate itself, we avoid causing additional spurious 'type annotations needed' errors after a 'real' error has already occurred. With this PR, the diagnostic changes caused by PR rust-lang#91205 are reverted.
Configuration menu - View commit details
-
Copy full SHA for 70a61c9 - Browse repository at this point
Copy the full SHA 70a61c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a14ae6f - Browse repository at this point
Copy the full SHA a14ae6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 408709d - Browse repository at this point
Copy the full SHA 408709dView commit details -
Configuration menu - View commit details
-
Copy full SHA for acd6476 - Browse repository at this point
Copy the full SHA acd6476View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0076b17 - Browse repository at this point
Copy the full SHA 0076b17View commit details
Commits on Jan 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4f0ad1c - Browse repository at this point
Copy the full SHA 4f0ad1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32ed6e5 - Browse repository at this point
Copy the full SHA 32ed6e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 406cc07 - Browse repository at this point
Copy the full SHA 406cc07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42cb17e - Browse repository at this point
Copy the full SHA 42cb17eView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 1e17daf - Browse repository at this point
Copy the full SHA 1e17dafView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb88166 - Browse repository at this point
Copy the full SHA cb88166View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2923f3a - Browse repository at this point
Copy the full SHA 2923f3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68976d1 - Browse repository at this point
Copy the full SHA 68976d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c63ec4 - Browse repository at this point
Copy the full SHA 1c63ec4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.