Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove List::is_noop #93077

Merged
merged 1 commit into from
Jan 20, 2022
Merged

remove List::is_noop #93077

merged 1 commit into from
Jan 20, 2022

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jan 19, 2022 •
edited
Loading

think that is_noop is actually less clear than just using is_empty

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 19, 2022
@rust-highfive
Copy link
Collaborator

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Jan 19, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 19, 2022

📌 Commit 4bd571c has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2022
@bors
Auto merge of rust-lang#93085 - matthiaskrgr:rollup-mgpu2ju, r=matthi…
237949b 
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#92316 (mangling_v0: Skip extern blocks during mangling)
 - rust-lang#92630 (Change PhantomData type for `BuildHasherDefault` (and more))
 - rust-lang#92800 (Add manifest docs fallback.)
 - rust-lang#93005 (Move back templates into html folder)
 - rust-lang#93065 (Pretty printer algorithm revamp step 2)
 - rust-lang#93077 (remove `List::is_noop`)

Failed merges:

 - rust-lang#93068 (Fix spacing for `·` between stability and source)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 43d508b into rust-lang:master Jan 20, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lcnr @rust-highfive @oli-obk @bors @rustbot