Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #92730

Closed
wants to merge 29 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

seanchen1991 and others added 29 commits October 22, 2021 12:21
It's already a (fat) reference.
Double referencing it creates lifetime issues for its methods that want to return iterators.
The doc states that instants are not steady, but the word "not" wasn't highlighted in bold.
Add `std::error::Report` type

This is a continuation of rust-lang#90174, split into a separate PR since I cannot push to ````@seanchen1991```` 's fork
rustc_metadata: Stop passing `CrateMetadataRef` by reference (step 1)

It's already a (fat) reference.
Double referencing it creates lifetime issues for its methods that want to return iterators.

---
Extracted from rust-lang#92245 for a perf run.
The PR changes a lot of symbol names due to function signature changes, so it's hard to do differential profiling, let's spend some machine time instead.
…uillaumeGomez

rustdoc: Preserve rendering of macro_rules matchers when possible

Fixes rust-lang#92331. This approach restores the behavior prior to rust-lang#86282 **if** the matcher token held by the compiler **and** the matcher token found in the source code are identical TokenTrees. Thus rust-lang#86208 remains fixed, but without regressing formatting for the vast majority of macros which are not macro-generated.
Allow unwinding from OOM hooks

This is split off from rust-lang#88098 and contains just the bare minimum to allow specifying a custom OOM hook with `set_alloc_error_hook` which unwinds instead of aborting.

See rust-lang#88098 for an actual command-line flag which switches the default OOM behavior to unwind instead of aborting.

Previous perf results show a negligible impact on performance.
… r=pietroalbini

RELEASES.md: Add 1.58 release note for `File::options` stabilization
Extended the note on the use of `no_run` attribute
Fix doc formatting for time.rs

The doc states that instants are not steady, but the word "not" wasn't highlighted in bold.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 10, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2022
@bors
Copy link
Contributor

bors commented Jan 10, 2022

⌛ Testing commit 35d408c with merge 6520c8a433720aab07d8dfa845b8a438d9d47e90...

@pietroalbini
Copy link
Member

@bors retry

Yield to the stable release.

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jan 10, 2022

⌛ Testing commit 35d408c with merge 8bf6b4c5d47beda4dd94cf1185efa6fac5eca885...

@camelid
Copy link
Member

camelid commented Jan 10, 2022

@bors retry (bors glitched and inappropriately landed a PR, retrying this to avoid issues)

@bors
Copy link
Contributor

bors commented Jan 10, 2022

⌛ Testing commit 35d408c with merge f340d4d3f893e551264561c352035567ac76aa13...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jan 11, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2022
@camelid
Copy link
Member

camelid commented Jan 11, 2022

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jan 11, 2022

⌛ Testing commit 35d408c with merge 0008091af64d87724652b993a81798d88d92e4cd...

@bors
Copy link
Contributor

bors commented Jan 11, 2022

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@hkratz
Copy link
Contributor

hkratz commented Jan 11, 2022

I don't think the timeout of dist-x86_64-msvc-alt is spurious, the build hangs at the same point during the stage 1 rust-analyzer build: 1, 2. Looking back rollup #92593 hat the exact same timeout: 3. The only shared PR is #92535, so it seems likely that that PR is at fault.

@camelid
Copy link
Member

camelid commented Jan 11, 2022

Yeah, when I retried it, I wondered if it could be that PR, but I thought it was worth retrying in case it was spurious.

@ehuss
Copy link
Contributor

ehuss commented Jan 13, 2022

Closing out a stale rollup.

@ehuss ehuss closed this Jan 13, 2022
@matthiaskrgr matthiaskrgr deleted the rollup-hgamkub branch February 13, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.