Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Introduce a resolver cache for sharing data between early doc link resolution and later passes #92608

Merged
merged 1 commit into from
Jan 9, 2022
Merged

rustdoc: Introduce a resolver cache for sharing data between early doc link resolution and later passes #92608

merged 1 commit into from
Jan 9, 2022

Conversation

petrochenkov
Copy link
Contributor

The refactoring parts of #88679, shouldn't cause any slowdowns.
r? @jyn514

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 6, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2022
@petrochenkov petrochenkov mentioned this pull request Jan 6, 2022
Merged
@jyn514
Copy link
Member

jyn514 commented Jan 6, 2022

I'm on vacation for a while.

r? rust-lang/rustdoc

@rust-highfive rust-highfive assigned CraftSpider and unassigned jyn514 Jan 6, 2022
@jyn514
Copy link
Member

jyn514 commented Jan 6, 2022

cc @CraftSpider

@CraftSpider
Copy link
Contributor

I'll try to review this tonight once I'm out of work

CraftSpider
CraftSpider reviewed Jan 7, 2022
View reviewed changes
Copy link
Contributor

@CraftSpider CraftSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, just have a couple questions before I feel comfortable approving this.

compiler/rustc_middle/src/query/mod.rs Outdated Show resolved Hide resolved
src/librustdoc/passes/collect_intra_doc_links/early.rs Show resolved Hide resolved
src/librustdoc/passes/collect_trait_impls.rs Outdated Show resolved Hide resolved
src/librustdoc/passes/collect_trait_impls.rs Show resolved Hide resolved
src/librustdoc/passes/collect_intra_doc_links/early.rs Show resolved Hide resolved
@bors

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2022
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 7, 2022
@CraftSpider
Copy link
Contributor

Thanks for the changes and comments, looks good
@bors r+

@bors
Copy link
Contributor

bors commented Jan 8, 2022

📌 Commit 5acd1f9 has been approved by CraftSpider

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2022
@bors
Auto merge of rust-lang#92690 - matthiaskrgr:rollup-rw0oz05, r=matthi…
f7bb8e3 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#92055 (Add release notes for 1.58)
 - rust-lang#92490 (Move crate drop-down to search results page)
 - rust-lang#92510 (Don't resolve blocks in foreign functions)
 - rust-lang#92573 (expand: Refactor InvocationCollector visitor for better code reuse)
 - rust-lang#92608 (rustdoc: Introduce a resolver cache for sharing data between early doc link resolution and later passes)
 - rust-lang#92657 (Implemented const casts of raw pointers)
 - rust-lang#92671 (Make `Atomic*::from_mut` return `&mut Atomic*`)
 - rust-lang#92673 (Remove useless collapse toggle on "all items" page)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 51001b3 into rust-lang:master Jan 9, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 9, 2022
dario23 added a commit to dario23/rust-semverver that referenced this pull request May 4, 2022
@dario23
FIXME: update to rust-lang/rust#92608
e66f3cb
dario23 added a commit to dario23/rust-semverver that referenced this pull request May 6, 2022
@dario23
Rustup to rust-lang/rust#92608
1aff824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CraftSpider CraftSpider CraftSpider left review comments

Assignees

@CraftSpider CraftSpider

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
6 participants
@petrochenkov @jyn514 @CraftSpider @bors @rust-highfive @rustbot