Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] Replace jemalloc with mimalloc beta branch #92317

Closed
wants to merge 3 commits into from

Conversation

fee1-dead
Copy link
Member

Like #92249 but uses the improved branch to test out max-rss regression

r? @ghost

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 27, 2021
@fee1-dead
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 27, 2021
@bors
Copy link
Contributor

bors commented Dec 27, 2021

⌛ Trying commit eb2a635 with merge d80254e2b2c9678b15cb8bc1950a01d08b59b706...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Dec 27, 2021

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 27, 2021
@fee1-dead fee1-dead marked this pull request as draft December 27, 2021 14:21
@fee1-dead
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Dec 27, 2021

⌛ Trying commit 2775e9e with merge dcee12e0ea11b4bb2057b3a2d79b33cf752ce689...

@rust-log-analyzer

This comment has been minimized.

@fee1-dead
Copy link
Member Author

Not sure what has happened but I don't know why the last try build was still using outdated versions.

@bors try

@bors
Copy link
Contributor

bors commented Dec 27, 2021

⌛ Trying commit 2775e9e with merge 4dc9cad6d0c28e39b1ea26eb8b43892606dc56b8...

@bors
Copy link
Contributor

bors commented Dec 27, 2021

☀️ Try build successful - checks-actions
Build commit: 4dc9cad6d0c28e39b1ea26eb8b43892606dc56b8 (4dc9cad6d0c28e39b1ea26eb8b43892606dc56b8)

@rust-timer
Copy link
Collaborator

Queued 4dc9cad6d0c28e39b1ea26eb8b43892606dc56b8 with parent f8abed9, future comparison URL.

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4dc9cad6d0c28e39b1ea26eb8b43892606dc56b8): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Moderate improvement in instruction counts (up to -1.9% on incr-unchanged builds of deeply-nested)
  • Very large regression in instruction counts (up to 9.8% on full builds of many-assoc-items)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 27, 2021
@bjorn3
Copy link
Member

bjorn3 commented Dec 27, 2021

This is now a regression for inst count but an improvement for max-rss.

@the8472
Copy link
Member

the8472 commented Dec 27, 2021

The wall-time results look worse than the instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants