-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experiment] Replace jemalloc with mimalloc beta branch #92317
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit eb2a635 with merge d80254e2b2c9678b15cb8bc1950a01d08b59b706... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
⌛ Trying commit 2775e9e with merge dcee12e0ea11b4bb2057b3a2d79b33cf752ce689... |
This comment has been minimized.
This comment has been minimized.
Not sure what has happened but I don't know why the last try build was still using outdated versions. @bors try |
⌛ Trying commit 2775e9e with merge 4dc9cad6d0c28e39b1ea26eb8b43892606dc56b8... |
☀️ Try build successful - checks-actions |
Queued 4dc9cad6d0c28e39b1ea26eb8b43892606dc56b8 with parent f8abed9, future comparison URL. |
Finished benchmarking commit (4dc9cad6d0c28e39b1ea26eb8b43892606dc56b8): comparison url. Summary: This change led to very large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
This is now a regression for inst count but an improvement for max-rss. |
The wall-time results look worse than the instructions. |
Like #92249 but uses the improved branch to test out max-rss regression
r? @ghost