Sync rustc_codegen_cranelift #92131
Merged
Sync rustc_codegen_cranelift #92131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were left over in migrations to subtrees, which should generally be treated as-if it was local. Also fixes a warning caused by this change.
Sync rustc_codegen_cranelift Nothing exciting this time. Mostly internal refactorings. r? `@ghost` `@rustbot` label +A-codegen +A-cranelift +T-compiler
TryInto is part of the 2021 edition prelude
Co-authored-by: bjorn3 <[email protected]>
This version no longer has the old x86 backend
Turn vtable_allocation() into a query This PR removes the untracked vtable-const-allocation cache from the `tcx` and turns the `vtable_allocation()` method into a query. The change is pretty straightforward and should be backportable without too much effort. Fixes rust-lang#89598.
As per the libs team decision in rust-lang#58935. Closes rust-lang#58935
Instead use the default_call_conv field on TargetFrontendConfig to get the default CallConv.
Remove `SymbolStr` This was originally proposed in rust-lang#74554 (comment). As well as removing the icky `SymbolStr` type, it allows the removal of a lot of `&` and `*` occurrences. Best reviewed one commit at a time. r? `@oli-obk`
rustbot
added
T-compiler
|
@bors r+ |
|
📌 Commit 3426a73 has been approved by |
bors
added
the
S-waiting-on-bors
What do you mean? https://doc.rust-lang.org/cargo/commands/cargo-vendor.html#description
|
|
They are incompatible with the current vendoring implementation in rustbuild at least. See #90764. |
|
⌛ Testing commit 3426a73 with merge 01dd87732bac1603a0647e380b839bf0eb3356ba... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry docker.io 503 |
bors
added
S-waiting-on-bors
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 21, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90345 (Stabilise entry_insert) - rust-lang#91412 (Improve suggestions for importing out-of-scope traits reexported as `_`) - rust-lang#91770 (Suggest adding a `#[cfg(test)]` to to a test module) - rust-lang#91823 (Make `PTR::as_ref` and similar methods `const`.) - rust-lang#92127 (Move duplicates removal when generating results instead of when displaying them) - rust-lang#92129 (JoinHandle docs: add missing 'the') - rust-lang#92131 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main highlight this sync is improved support for inline assembly. Thanks @nbdd0121! Inline assembly is still disabled by default for builds in the main rust repo though. Cranelift will now also be built from the crates.io releases rather than the git repo. Git repos are incompatible with vendoring.
r? @ghost
@rustbot label +A-codegen +A-cranelift +T-compiler