Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 3 pull requests #91320

Merged
merged 7 commits into from
Nov 28, 2021
Merged

Rollup of 3 pull requests #91320

merged 7 commits into from
Nov 28, 2021

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

oli-obk and others added 7 commits November 26, 2021 14:22
…asper

Perform Sync check on static items in wf-check instead of during const checks

r? `@RalfJung`

This check is solely happening on the signature of the static item and not on its body, therefor it belongs into wf-checking instead of const checking.
Fix ICE when lowering `trait A where for<'a> Self: 'a`

Fixes rust-lang#88586.

r? `@jackh726`

Jack, this fix is much smaller in scope than what I think you were proposing in the issue. Let me know if you had a vision for a larger refactor here.

cc `@JohnTitor`
Change output path to {{build-base}} for rustdoc scrape_examples ui test

See rust-lang#90611 (comment)

r? `@jyn514`

cc `@petrochenkov`
@rustbot rustbot added the rollup A PR which is a rollup label Nov 28, 2021
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Contributor

bors commented Nov 28, 2021

📌 Commit a7639b6 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 28, 2021
@bors
Copy link
Contributor

bors commented Nov 28, 2021

⌛ Testing commit a7639b6 with merge db9d361...

@bors
Copy link
Contributor

bors commented Nov 28, 2021

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing db9d361 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 28, 2021
@bors bors merged commit db9d361 into rust-lang:master Nov 28, 2021
@rustbot rustbot added this to the 1.59.0 milestone Nov 28, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (db9d361): comparison url.

Summary: This change led to large relevant improvements 🎉 in compiler performance.

  • Large improvement in instruction counts (up to -3.9% on incr-unchanged builds of deep-vector)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@matthiaskrgr matthiaskrgr deleted the rollup-r209seq branch December 12, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants