Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some tests to more reasonable directories - 9 #90837

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

c410-f3r
Copy link
Contributor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2021
@petrochenkov
Copy link
Contributor

Could you make a new subdirectory named stdlib-unit-tests?
It will contain tests that need to be moved to standard library unit tests (or removed if they are redundant), but that move is not done yet.
And also one more subdirectory named runtime for testing the standard library runtime facilities.

After that:

alloca-from-derived-tydesc.rs - can be removed now
estr-uniq.rs - can be removed now
seq-compare.rs - stdlib-unit-tests
lazy-init.rs - borrowck
readalias.rs - can be removed now
writealias.rs - can be removed now
utf8_idents-rpass.rs - parser
commandline-argfile.rs - already moved in #90560
running-with-no-runtime.rs - runtime
resolve-issue-2428.rs - resolve
use_inline_dtor.rs - drop
names-of-variants-in-std.rs - stdlib-unit-tests
expr-if.rs - expr/if
semistatement-in-lambda.rs - closures (or parser)
linkage1.rs - linkage-attr
reexport-should-still-link.rs - not sure, cross-crate, or can be removed
signal-alternate-stack-cleanup.rs - runtime
dead-extern-static-no-warning.rs - lint
use-crate-name-alias.rs - can be removed now
instantiable.rs - recursion
c-stack-returning-int64.rs - abi
purity-infer.rs - can be removed now
eq-multidispatch.rs - stdlib-unit-tests
syntax-impl-for-dotdot.rs - parser
export-import.rs - privacy, or can be removed (was testing a long removed export system)
export-multi.rs - can be removed now (was testing a long removed export system)
export-non-interference2.rs - can be removed now (was testing a long removed export system)
export-non-interference3.rs - can be removed now (was testing a long removed export system)
export2.rs - can be removed now (was testing a long removed export system)
similar-tokens.rs - parser
static_sized_requirement.rs - static
lifetime-before-type-params.rs - generics
object-lifetime-*.rs - object-lifetime
macro-quote-cond.rs - proc-macro
proc_macro.rs - proc-macro
while-let.rs - for-loop-while
type-in-nested-module.rs - can be removed now
default-alloc-error-hook.rs - alloc-error?
ranges-precedence.rs -> parser
shift-various-bad-types.rs -> binop?
crate-in-paths.rs -> resolve
attr-usage-repr.rs -> repr
out-of-stack.rs -> runtime
augmented-assignments-feature-gate.rs - can be removed now
builtin-clone.rs -> stdlib-unit-tests
istr.rs -> stdlib-unit-tests
ret-none.rs - can be removed now
question-mark-type-infer.rs - inference (there two similar subdirectories - inference and type-inference, but inference seems to be larger)
prim-with-args.rs - typeck
expr-block-unique.rs - can be removed now
owned-implies-static.rs - regions maybe
typeclasses-eq-example-static.rs - traits

+

rt-explody-panic-payloads.rs - runtime
stdout-during-shutdown.rs - runtime

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2021
@c410-f3r
Copy link
Contributor Author

Could you make a new subdirectory named stdlib-unit-tests? It will contain tests that need to be moved to standard library unit tests (or removed if they are redundant), but that move is not done yet. And also one more subdirectory named runtime for testing the standard library runtime facilities.

After that:

alloca-from-derived-tydesc.rs - can be removed now estr-uniq.rs - can be removed now seq-compare.rs - stdlib-unit-tests lazy-init.rs - borrowck readalias.rs - can be removed now writealias.rs - can be removed now utf8_idents-rpass.rs - parser commandline-argfile.rs - already moved in #90560 running-with-no-runtime.rs - runtime resolve-issue-2428.rs - resolve use_inline_dtor.rs - drop names-of-variants-in-std.rs - stdlib-unit-tests expr-if.rs - expr/if semistatement-in-lambda.rs - closures (or parser) linkage1.rs - linkage-attr reexport-should-still-link.rs - not sure, cross-crate, or can be removed signal-alternate-stack-cleanup.rs - runtime dead-extern-static-no-warning.rs - lint use-crate-name-alias.rs - can be removed now instantiable.rs - recursion c-stack-returning-int64.rs - abi purity-infer.rs - can be removed now eq-multidispatch.rs - stdlib-unit-tests syntax-impl-for-dotdot.rs - parser export-import.rs - privacy, or can be removed (was testing a long removed export system) export-multi.rs - can be removed now (was testing a long removed export system) export-non-interference2.rs - can be removed now (was testing a long removed export system) export-non-interference3.rs - can be removed now (was testing a long removed export system) export2.rs - can be removed now (was testing a long removed export system) similar-tokens.rs - parser static_sized_requirement.rs - static lifetime-before-type-params.rs - generics object-lifetime-*.rs - object-lifetime macro-quote-cond.rs - proc-macro proc_macro.rs - proc-macro while-let.rs - for-loop-while type-in-nested-module.rs - can be removed now default-alloc-error-hook.rs - alloc-error? ranges-precedence.rs -> parser shift-various-bad-types.rs -> binop? crate-in-paths.rs -> resolve attr-usage-repr.rs -> repr out-of-stack.rs -> runtime augmented-assignments-feature-gate.rs - can be removed now builtin-clone.rs -> stdlib-unit-tests istr.rs -> stdlib-unit-tests ret-none.rs - can be removed now question-mark-type-infer.rs - inference (there two similar subdirectories - inference and type-inference, but inference seems to be larger) prim-with-args.rs - typeck expr-block-unique.rs - can be removed now owned-implies-static.rs - regions maybe typeclasses-eq-example-static.rs - traits

rt-explody-panic-payloads.rs - runtime stdout-during-shutdown.rs - runtime

Done

@c410-f3r
Copy link
Contributor Author

It is worth noting that parse reached 1000 entries

@petrochenkov
Copy link
Contributor

It is worth noting that parse reached 1000 entries

I think we can add a tidy exception to parser for now, if it's necessary.
It's a much more reasonable subdirectory than issues and the root.
I have ideas how to split it, e.g. the lexer stuff can be moved to lexer, but it's a task for a separate PR.

shift-various-bad-types.rs -> binop
syntax-impl-for-dotdot.rs -> parser
similar-tokens.rs -> parser
ranges-precedence.rs -> parser

@c410-f3r
Copy link
Contributor Author

I have ideas how to split it, e.g. the lexer stuff can be moved to lexer, but it's a task for a separate PR.

Yes, please.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2021

📌 Commit ab5434f has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#85766 (Stabilize File::options())
 - rust-lang#88601 (Implement `Termination` for `Result<Infallible, E>`)
 - rust-lang#90058 (Stabilize -Z strip as -C strip)
 - rust-lang#90790 (Fix standard library test with read_link)
 - rust-lang#90834 (Android is not GNU)
 - rust-lang#90835 (Rename WASI's `is_character_device` to `is_char_device`.)
 - rust-lang#90837 (Move some tests to more reasonable directories - 9)
 - rust-lang#90848 (Remove bigint_helper_methods for *signed* types)
 - rust-lang#90892 (fix ICE on Miri/CTFE copy of half a pointer)
 - rust-lang#90909 (disable portable SIMD tests in Miri)

Failed merges:

 - rust-lang#90128 (Stabilize -Z symbol-mangling-version=v0 as -C symbol-mangling-version=v0)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 12d5297 into rust-lang:master Nov 16, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants