Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[inline]s to SortedIndexMultiMap #90787

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Add #[inline]s to SortedIndexMultiMap #90787

merged 1 commit into from
Nov 17, 2021

Conversation

JohnTitor
Copy link
Member

They're small enough and good candidates to add #[inline] generally.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 10, 2021
@JohnTitor
Copy link
Member Author

I haven't run perf check on my local, let's see if it has a noticeable effect.
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 10, 2021
@bors
Copy link
Contributor

bors commented Nov 10, 2021

⌛ Trying commit 8d4fbc9 with merge 9dd6c98670de460a5586da554d5edf6bbe5e31d1...

@bors
Copy link
Contributor

bors commented Nov 11, 2021

☀️ Try build successful - checks-actions
Build commit: 9dd6c98670de460a5586da554d5edf6bbe5e31d1 (9dd6c98670de460a5586da554d5edf6bbe5e31d1)

@rust-timer
Copy link
Collaborator

Queued 9dd6c98670de460a5586da554d5edf6bbe5e31d1 with parent 82af160, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9dd6c98670de460a5586da554d5edf6bbe5e31d1): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 11, 2021
@JohnTitor
Copy link
Member Author

The result says that there's no big positive effect, but I guess it's fine to add them in general (if wg-grammar debug's regression is noise), how about?

@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 11, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Nov 16, 2021

No strong opinion on my end, so

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 16, 2021

📌 Commit 8d4fbc9 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 16, 2021
@matthiaskrgr
Rollup merge of rust-lang#90787 - JohnTitor:inline-sorted-index-map, …
82b2504 
…r=oli-obk

Add `#[inline]`s to `SortedIndexMultiMap`

They're small enough and good candidates to add `#[inline]` generally.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 16, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 16, 2021
@matthiaskrgr
Rollup merge of rust-lang#90787 - JohnTitor:inline-sorted-index-map, …
d94dc8d 
…r=oli-obk

Add `#[inline]`s to `SortedIndexMultiMap`

They're small enough and good candidates to add `#[inline]` generally.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 16, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 16, 2021
@matthiaskrgr
Rollup merge of rust-lang#90787 - JohnTitor:inline-sorted-index-map, …
77f42c2 
…r=oli-obk

Add `#[inline]`s to `SortedIndexMultiMap`

They're small enough and good candidates to add `#[inline]` generally.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 16, 2021
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 16, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2021
@bors
Auto merge of rust-lang#90966 - matthiaskrgr:rollup-4akzcrh, r=matthi…
41301c3 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#90733 (Build musl dist artifacts with debuginfo enabled)
 - rust-lang#90787 (Add `#[inline]`s to `SortedIndexMultiMap`)
 - rust-lang#90920 (:arrow_up: rust-analyzer)
 - rust-lang#90933 (Fix await suggestion on non-future type)
 - rust-lang#90935 (Alphabetize language features)
 - rust-lang#90949 (update miri)
 - rust-lang#90958 (Mark `<*const _>::align_offset` and `<*mut _>::align_offset` as `const fn`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c63cf07 into rust-lang:master Nov 17, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 17, 2021
@JohnTitor JohnTitor deleted the inline-sorted-index-map branch November 17, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
7 participants
@JohnTitor @rust-highfive @rust-timer @bors @oli-obk @apiraino @rustbot