Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 8 pull requests #90416

Merged
merged 20 commits into from
Oct 30, 2021
Merged

Rollup of 8 pull requests #90416

merged 20 commits into from
Oct 30, 2021

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

AlexApps99 and others added 20 commits October 22, 2021 10:03
@AlexApps99
Added const versions of common numeric operations
23d033e 
# Conflicts:
#	library/core/src/lib.rs
@AlexApps99
Added docs to internal_macro const
361c978
@Veykril
Fix incorrect doc link
29a4e4a
@WaffleLapkin
Make core::slice::from_raw_parts[_mut] const
991a296
@b-naber
don't mutably borrow inner infcx in all of ConstInferUnifier::consts
04cb196
@b-naber
add test
a39c50b
@b-naber
ignore type flags insertion in default_anon_const_substs if error occ…
87fbf3c 
…urred
@wesleywiser
Add a few query descriptions
60bf2f1
@GuillaumeGomez
Unify titles in rustdoc book doc attributes chapter
0c70831
@WaffleLapkin
Use proper issue number for feature(const_slice_from_raw_parts)
878ac10
@WaffleLapkin
Apply changes proposed in the review
afaa54a
@jyn514
Remove unnecessary macro_uses in rustdoc
b6851ba
@matthiaskrgr
Rollup merge of rust-lang#89876 - AlexApps99:const_ops, r=oli-obk
20bb932 
Make most std::ops traits const on numeric types

This PR makes existing implementations of `std::ops` traits (`Add`, `Sub`, etc) [`impl const`](rust-lang#67792) where possible.
This affects:
- All numeric primitives (`u*`, `i*`, `f*`)
- `NonZero*`
- `Wrapping`

This is under the `rustc_const_unstable` feature `const_ops`.
I will write tests once I know what can and can't be kept for the final version of this PR.

Since this is my first PR to rustc (and hopefully one of many), please give me feedback on how to better handle the PR process wherever possible. Thanks

[Zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/Const.20std.3A.3Aops.20traits.20PR)
@matthiaskrgr
Rollup merge of rust-lang#90371 - Veykril:patch-2, r=jyn514
86087f9 
Fix incorrect doc link

Looks like a copy paste mistake
@matthiaskrgr
Rollup merge of rust-lang#90374 - GuillaumeGomez:unify-rustdoc-book-t…
a213740 
…itles, r=camelid

Unify titles in rustdoc book doc attributes chapter

As discussed in rust-lang#90339.

I wasn't able to find out where the link to the titles was used so let's see if the CI fails. :)

r? ``@camelid``
@matthiaskrgr
Rollup merge of rust-lang#90377 - WaffleLapkin:const_slice_from_raw_p…
b531364 
…arts, r=oli-obk

Make `core::slice::from_raw_parts[_mut]` const

Responses to rust-lang#90012 seem to allow ``@rust-lang/wg-const-eval`` to decide on use of `const_eval_select`, so we can make `core::slice::from_raw_parts[_mut]` const :)

---
This PR marks the following APIs as const:
```rust
// core::slice
pub const unsafe fn from_raw_parts<'a, T>(data: *const T, len: usize) -> &'a [T];
pub const unsafe fn from_raw_parts_mut<'a, T>(data: *mut T, len: usize) -> &'a mut [T];
```
---

Resolves rust-lang#90011
r? ``@oli-obk``
@matthiaskrgr
Rollup merge of rust-lang#90395 - b-naber:const-expr-type-relation, r…
88e0bea 
…=oli-obk

Restrict liveness of mutable borrow of inner infcx in ConstInferUnifier::consts

Fixes rust-lang#89304

r? ``@oli-obk``
@matthiaskrgr
Rollup merge of rust-lang#90396 - b-naber:type_flags_ices_default_ano…
d99dc7a 
…n_consts, r=lcnr

Prevent type flags assertions being thrown in default_anon_const_substs if errors occurred

Fixes rust-lang#90364
Fixes rust-lang#88997

r? ``@lcnr``
@matthiaskrgr
Rollup merge of rust-lang#90402 - wesleywiser:query_descriptions, r=o…
f9111e0 
…li-obk

Add a few query descriptions
@matthiaskrgr
Rollup merge of rust-lang#90412 - jyn514:macro-use, r=camelid
19b5b0f 
Remove unnecessary `macro_use`s in rustdoc
@rustbot rustbot added the rollup A PR which is a rollup label Oct 30, 2021
@matthiaskrgr
Copy link
Member Author

@bors r+ p=8 rollup=never

@bors
Copy link
Contributor

bors commented Oct 30, 2021

📌 Commit 19b5b0f has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 30, 2021
@bors
Copy link
Contributor

bors commented Oct 30, 2021

⌛ Testing commit 19b5b0f with merge 9f13083...

@bors
Copy link
Contributor

bors commented Oct 30, 2021

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 9f13083 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 30, 2021
@bors bors merged commit 9f13083 into rust-lang:master Oct 30, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 30, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9f13083): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

  • Large regression in instruction counts (up to 2.7% on full builds of helloworld)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Oct 30, 2021
@pnkfelix
Copy link
Member

pnkfelix commented Nov 2, 2021

All the significant perf regressions are to doc generation. (Which many do seem to have regressed by 1.0-2.7%.)

@pnkfelix pnkfelix mentioned this pull request Nov 2, 2021
Open
@pnkfelix
Copy link
Member

pnkfelix commented Nov 2, 2021

Filed as #90512

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 2, 2021
@matthiaskrgr matthiaskrgr deleted the rollup-55lzqng branch November 20, 2021 15:03
@the8472
Copy link
Member

the8472 commented Nov 23, 2021

@pnkfelix

not just the doc regressions are significant, the opt ones are smaller but non-noise

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.