Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #90178

Closed
wants to merge 111 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

calebcartwright and others added 30 commits July 25, 2021 22:57
* dirs-sys v0.3.4 -> v0.3.6 to drop a lot of deps
regex v1.3.1 -> v1.4.3 drops thread_local 0.3.6
bytecount v0.6.0 -> v0.6.2 replaces packed_simd with packed_simd_2
ignore v0.4.11 -> v0.4.17 drop crossbeam-channel v0.4.0

* itertools 8.0 -> 9.0
bump `ignore` version in Cargo.toml

* cargo_metadata 0.8 -> 0.12

* env_logger 0.6 -> 0.8
Since RFC 3052 soft deprecated the authors field anyway, hiding it from
crates.io, docs.rs, and making Cargo not add it by default, and it is
not generally up to date/useful information, we should remove it from
crates in this repo.
rfc3052 followup: Remove authors field from Cargo manifests

Since RFC 3052 soft deprecated the authors field, hiding it from
crates.io, docs.rs, and making Cargo not add it by default, and it is
not generally up to date/useful information for contributors, we may as well
remove it from crates in this repo.
This is possible now that rustdoc allows passing
`--document-private-items` more than once.
…mulacrum

Document private items for rustfmt

This is possible now that rust-lang#73936 has been merged.
A demonstration of the fix is included in the PR associated with this
commit.
Separates out search and direct linking, uses header ids for direct linking and `?search=term` for filtering configurations.
Once the app mounts the page is scrolled to the current header set in the url hash.
* Adds query param for version no

This adds support for using a query parameter for selecting the version no

* Adds error handling to configuration request

Catch request exception in case fetching the configuration from the url fails, this can happen either if non existent version number is passed in or because of server issues.

* Makes version selection better

Covers a few common cases in which the version number can be specified.
- Preserve search and version parameter updates in the url
- Render headings with an anchor to itself for easier linking to config
  options, variants, etc.

Demo: https://5efeb81ca3f0d.htmlsave.net/
Older tags of the repo don't have the configuration.md file
that the docs/index.html file uses to display configuration options.
Removing them from the list since they don't apply to the use case of the
documentation page.
Signed-off-by: gunadhya <[email protected]>
hudson-ayers and others added 16 commits October 21, 2021 10:44
This addresses a TODO comment. The behavior of #[derive(Clone)]
*does* result in a T: Clone requirement.

Add a manual Clone implementation, matching Split and SplitInclusive.
Implement split_array and split_array_mut

This implements `[T]::split_array::<const N>() -> (&[T; N], &[T])` and `[T; N]::split_array::<const M>() -> (&[T; M], &[T])` and their mutable equivalents. These are another few “missing” array implementations now that const generics are a thing, similar to rust-lang#74373, rust-lang#75026, etc. Fixes rust-lang#74674.

This implements `[T; N]::split_array` returning an array and a slice. Ultimately, this is probably not what we want, we would want the second return value to be an array of length N-M, which will likely be possible with future const generics enhancements. We need to implement the array method now though, to immediately shadow the slice method. This way, when the slice methods get stabilized, calling them on an array will not be automatic through coercion, so we won't have trouble stabilizing the array methods later (cf. into_iter debacle).

An unchecked version of `[T]::split_array` could also be added as in rust-lang#76014. This would not be needed for `[T; N]::split_array` as that can be compile-time checked. Edit: actually, since split_at_unchecked is internal-only it could be changed to be split_array-only.
…aahc

Stabilise unix_process_wait_more, extra ExitStatusExt methods

This stabilises the feature `unix_process_wait_more`.  Tracking issue rust-lang#80695, FCP needed.

This was implemented in rust-lang#79982 and merged in January.
Added next_up and next_down for f32/f64.

This is a pull request implementing the features described at rust-lang/rfcs#3173.
…ackh726

add feature flag for `type_changing_struct_update`

This implements the PR0 part of the mentoring notes within rust-lang#86618.

overrides the previous inactive rust-lang#86646 pr.

r? ``@nikomatsakis``
…l, r=davidtwco

Implement -Z location-detail flag

This PR implements the `-Z location-detail` flag as described in rust-lang/rfcs#2091 .

`-Z location-detail=val` controls what location details are tracked when using `caller_location`. This allows users to control what location details are printed as part of panic messages, by allowing them to exclude any combination of filenames, line numbers, and column numbers. This option is intended to provide users with a way to mitigate the size impact of `#[track_caller]`.

Some measurements of the savings of this approach on an embedded binary can be found here: rust-lang#70579 (comment) .

Closes rust-lang#70580 (unless people want to leave that open as a place for discussion of further improvements).

This is my first real PR to rust, so any help correcting mistakes / understanding side effects / improving my tests is appreciated :)

I have one question: RFC 2091 specified this as a debugging option (I think that is what -Z implies?). Does that mean this can never be stabilized without a separate MCP? If so, do I need to submit an MCP now, or is the initial RFC specifying this option sufficient for this to be merged as is, and then an MCP would be needed for eventual stabilization?
…r=Mark-Simulacrum

Add edition configuration to compiletest

This allows the compiletest configuration to set a default edition that can still be overridden with header annotations. Doing this will make it far easier for clippy to get our tests to the newest edition.

r? ``@Manishearth``
…calebcartwright

Sync rustfmt subtree

There's a large number of small fixes and new features, but nothing too big. Detailed changelog for those interested can be found in https://github.com/rust-lang/rustfmt/blob/master/CHANGELOG.md#1438-2021-10-20
Make RSplit<T, P>: Clone not require T: Clone

This addresses a TODO comment. The behavior of `#[derive(Clone)]` *does* result in a `T: Clone` requirement. Playground example:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=a8b1a9581ff8893baf401d624a53d35b

Add a manual `Clone` implementation, mirroring `Split` and `SplitInclusive`.
`(R)?SplitN(Mut)?` don't have any `Clone` implementations, but I'll leave that for its own pull request.
Add comment documenting why we can't use a simpler solution

See rust-lang#90144 for context.

r? ``@joshtriplett``
@rustbot rustbot added the rollup A PR which is a rollup label Oct 22, 2021
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=9

@bors
Copy link
Contributor

bors commented Oct 22, 2021

📌 Commit 0375880 has been approved by matthiaskrgr

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 22, 2021
@bors
Copy link
Contributor

bors commented Oct 22, 2021

⌛ Testing commit 0375880 with merge f9e86b819c8af939974a4dc6da0824184523f3b9...

@rust-log-analyzer
Copy link
Collaborator

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test [ui] ui/panics/issue-47429-short-backtraces.rs#v0 ... ok
test [ui] ui/panics/issue-47429-short-backtraces.rs#legacy ... ok
test [ui] ui/panics/fmt-panic.rs ... ok
test [ui] ui/out-of-stack.rs ... ok
test [ui] ui/panics/location-detail-panic-no-column.rs ... ok
test [ui] ui/panics/panic-2021.rs ... ok
test [ui] ui/panics/location-detail-unwrap-no-file.rs ... ok
test [ui] ui/panic-runtime/abort.rs ... ok
test [ui] ui/panic-runtime/abort.rs ... ok
test [ui] ui/panics/location-detail-panic-no-line.rs ... ok
test [ui] ui/panics/location-detail-panic-no-file.rs ... ok
test [ui] ui/panics/panic-arg.rs ... ok
test [ui] ui/panics/panic-macro-any-wrapped.rs ... ok
test [ui] ui/panics/panic-macro-fmt.rs ... ok
test [ui] ui/panics/panic-macro-explicit.rs ... ok
---
test [ui] ui/panics/fmt-panic.rs ... ok
test [ui] ui/panics/issue-47429-short-backtraces.rs#v0 ... ok
test [ui] ui/panics/panic-2021.rs ... ok
test [ui] ui/panic-while-printing.rs ... ok
test [ui] ui/panics/location-detail-panic-no-column.rs ... ok
test [ui] ui/panics/location-detail-unwrap-no-file.rs ... ok
test [ui] ui/panics/location-detail-panic-no-file.rs ... ok
test [ui] ui/panics/location-detail-panic-no-line.rs ... ok
test [ui] ui/panics/main-panic.rs ... ok
test [ui] ui/panics/panic-macro-any-wrapped.rs ... ok
test [ui] ui/panics/panic-macro-any.rs ... ok
test [ui] ui/panics/panic-macro-fmt.rs ... ok
---
test sync::mpsc::tests::stress_recv_timeout_two_threads ... ok

failures:

---- f32::tests::test_next_down stdout ----
thread 'f32::tests::test_next_down' panicked at 'assertion failed: `(left == right)`
 right: `2140493141`', library/std/src/f32/tests.rs:335:5


---- f32::tests::test_next_up stdout ----
thread 'f32::tests::test_next_up' panicked at 'assertion failed: `(left == right)`
 right: `2140493141`', library/std/src/f32/tests.rs:304:5

---- f64::tests::test_next_down stdout ----
---- f64::tests::test_next_down stdout ----
thread 'f64::tests::test_next_down' panicked at 'assertion failed: `(left == right)`
 right: `9219619037165300394`', library/std/src/f64/tests.rs:336:5


---- f64::tests::test_next_up stdout ----
thread 'f64::tests::test_next_up' panicked at 'assertion failed: `(left == right)`
 right: `9219619037165300394`', library/std/src/f64/tests.rs:305:5


failures:
failures:
    f32::tests::test_next_down
    f32::tests::test_next_up
    f64::tests::test_next_down
    f64::tests::test_next_up

test result: FAILED. 904 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.36s

error: test failed, to rerun pass '-p std --lib'


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "i586-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/library/test/Cargo.toml" "-p" "std" "--"


Build completed unsuccessfully in 0:26:43

@bors
Copy link
Contributor

bors commented Oct 23, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 23, 2021
@matthiaskrgr matthiaskrgr deleted the rollup-hzgouzd branch November 20, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.