-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the minimum external LLVM to 11 #90062
Conversation
This comment has been minimized.
This comment has been minimized.
@bors r+ |
📌 Commit 5a87d1a has been approved by |
Update the minimum external LLVM to 11 With this change, we'll have stable support for LLVM 11..=13. For reference, the previous increase to LLVM 10 was rust-lang#83387. r? `@nagisa` `@nikic`
@rust-lang/wg-llvm How would you all feel about jumping to LLVM 12 right now? #90042 is struggling with codegen issues in llvm-10, which they also find to be a problem with system llvm-11, but not llvm-12. There's discussion in the zulip 1.57 bootstrap topic. (cc @rust-lang/release) For my own part, I currently only need LLVM 11 support for Fedora 33, which will be EOL before 1.58 comes out. |
I'm comfortable with us maintaining just the current and previous releases of LLVM in general. That has been the case at some points in the past as well. Otherwise requests for support beyond these LLVM versions tend to come from either distributions or, sometimes, people trying to utilize cross-lang LTO. |
See #90175, and if that's approved, don't forget to |
Update the minimum external LLVM to 11 With this change, we'll have stable support for LLVM 11..=13. For reference, the previous increase to LLVM 10 was rust-lang#83387. r? `@nagisa` `@nikic`
Failed in a rollup: #90200 (comment) |
Thanks -- pushed a fix in #90175. |
Update the minimum external LLVM to 12 With this change, we'll have stable support for LLVM 12 and 13. For reference, the previous increase to LLVM 10 was rust-lang#83387, and this replaces the pending increase to LLVM 11 in rust-lang#90062. r? `@nagisa` `@nikic`
With this change, we'll have stable support for LLVM 11..=13.
For reference, the previous increase to LLVM 10 was #83387.
r? @nagisa @nikic