Cfg hide more conditions for core and alloc #89668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Oct 8, 2021
|
Thanks! r=me once CI pass |
|
This also affects |
|
It does indeed: https://doc.rust-lang.org/nightly/alloc/index.html @Urgau: Please add the fix there as well. |
Urgau
changed the title
Done |
GuillaumeGomez
approved these changes
Oct 8, 2021
KamilaBorowska
approved these changes
Oct 8, 2021
|
Let's try that. @bors r=GuillaumeGomez rollup EDIT: Well, didn't worked as planned. Sorry for the noise. |
|
@Urgau: 🔑 Insufficient privileges: Not in reviewers |
|
@Urgau: 🔑 Insufficient privileges: not in try users |
|
@bors r=GuillaumeGomez rollup |
|
📌 Commit 0a03ec4 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Oct 8, 2021
Cfg hide more conditions for core and alloc Fixes rust-lang#89663 Before:  After:  *Same for alloc* r? `@GuillaumeGomez`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 8, 2021
…laumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#86506 (Don't normalize xform_ret_ty during method candidate assembly ) - rust-lang#89538 (Make rustdoc not highlight `->` and `=>` as operators) - rust-lang#89649 (clippy::complexity fixes) - rust-lang#89668 (Cfg hide more conditions for core and alloc) - rust-lang#89669 (Remove special-casing of never primitive in rustdoc-json-types) - rust-lang#89672 (Remove unwrap_or! macro) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89663
Before:
After:
Same for alloc
r? @GuillaumeGomez